Commit Graph

28 Commits

Author SHA1 Message Date
Noah Lev 2889c292cb
Triage some date-check items (#1513) 2022-11-26 22:25:58 +09:00
Tshepang Mbambo 2557089a44
make date-check more lightweight (#1394)
* make date-check lightweight

This avoids having to write the date twice when updating date-check.

Before "As of <-- 2022-07 --> July 2022"
After "As of July 2022"

* please clippy

* update date-check docs

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#pullrequestreview-1042163557

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#pullrequestreview-1042167261

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#issuecomment-1189105017

* this breaks markdown

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018268

This led to a more robust regex, though making the tool more picky.
It also found a wrong date format that was missed.

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018419

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018816

* accept review suggestion

This was reverted by mistake

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934019395

* use a more simple fn

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018981

Much more clean

* nit

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* avoid a failed regex

Also, test new shape

* adjust to new regex (which uses named groups)

New regex was introduced by 456008cc35

Co-authored-by: Noah Lev <camelidcamel@gmail.com>
2022-08-02 13:50:32 -07:00
Yuki Okushi e827b0aaa1 Update some date refs 2022-04-20 13:09:19 -07:00
Ivor Wanders 885d329928
Consolidate crates.io convention section (#1326) 2022-04-11 22:51:22 +09:00
Nicholas Nethercote acc6718c51 Address review comments in #1286. 2022-01-05 23:26:43 -06:00
Nicholas Nethercote a992723654 Streamline "Getting Started" some more.
This is a follow-up to #1279.

The "Getting Started" chapter is, TBH, pretty bad when it comes to the
stuff about building and testing. It has far too much detail and lots of
repetition, which would be overwhelming to a newcomer.

This commit removes most of it, leaving behind just quick mentions of
the most common `x.py` commands: `check`, `build`, `test`, `fmt`, with
links to the appropriate chapters for details. There were a few
interesting details that weren't covered elsewhere, so I moved those
into other chapters.
2022-01-05 23:26:43 -06:00
Jakob Degen d35a4c4bcb Remove reference to copyright notices.
Immediately below the section on copyright notices being removed,
it is mentioned that a particular thing should be placed below the
notices. This seems confusing.
2020-09-24 11:45:35 -04:00
Bastian Kauschke 8a9a1f935f
update conventions (#735)
* update conventions

* typo

Co-authored-by: Santiago Pastorino <spastorino@gmail.com>

Co-authored-by: Santiago Pastorino <spastorino@gmail.com>
2020-06-05 13:06:39 -03:00
Santiago Pastorino 27269235d3
Update some projects locations (#658) 2020-04-02 18:40:15 +02:00
Chris Simpkins 56cff94ce7
Update ./x.py tidy testing documentation (#607)
* update all docs to use ./x.py test tidy syntax
2020-03-10 12:02:24 +09:00
YOUNGSUK KIM 423808fb45 minor grammar fixes 2019-12-28 17:02:38 -06:00
Mazdak Farrokhzad 2dd722b173 Please don't rustfmt. 2019-11-05 09:10:33 -06:00
Mark Mansi f55e97c145 fix typos 2019-06-15 17:29:12 -05:00
Eduard-Mihai Burtescu f675e36941 Update for TyCtxt<'a, 'gcx, 'tcx> -> TyCtxt<'tcx>. 2019-06-15 16:58:30 -05:00
Mark Mansi bb3392e7d7 update conventions 2019-01-23 12:56:40 -06:00
Mark Mansi 952f9366b2 update text about copyright headers 2019-01-23 12:41:18 -06:00
Alcaro 946e11a578 conventions: Fix semicolon/colon typo 2018-09-28 20:04:05 -05:00
Josh Triplett 1f8e117292 Update copyright guidance to omit notices for new files.
Previously approved in https://github.com/rust-lang/rust/pull/43498 ;
update the guide to match.
2018-08-20 11:08:22 -05:00
mark 37a202cdba fix all the not-en-dashes 2018-07-09 21:45:49 -05:00
Sunjay Varma 0dc0dddb79 Closing all <a> tags 2018-05-10 14:46:44 -05:00
gnzlbg e39ea751a0 Add how to run tidy script in isolation to text
This is already mentioned elsewhere, but important things are repeated twice.

Closes #124
2018-05-08 09:57:21 -05:00
varkor 43341c8894 Consolidate and fix code blocks 2018-04-06 14:18:08 -05:00
Mark Mansi 42ef2ad0b8 Fix long lines in conventions 2018-03-26 20:28:00 -05:00
Phlosioneer 8a005f5dac Fix typo in conventions.md 2018-03-06 19:09:22 -06:00
Niko Matsakis c7c80abb0b remove humorous footnote which is not supported 2018-02-17 10:51:29 -06:00
Niko Matsakis caea7ae5ad mention tidy 2018-02-17 10:51:29 -06:00
Niko Matsakis 14f74dff91 add some more conventions 2018-02-17 10:51:29 -06:00
Niko Matsakis 8c657b1f88 add some notes on coding conventions and link to copyright notice 2018-02-17 10:51:29 -06:00