Shoshin Nikita d0768c9130 internal/lsp/source/completion: suggest only valid package names ... Before this change directory names were used "as is" for package completion. It could lead to invalid suggestions (for example, 'package 1abc' or package 'ab-cd'). This change adds a check whether a directory name can be used in a package path. If the directory name is invalid, only 'package main' will be suggested. Otherwise, the directory name will be normalized and will be used as a package name. Note: normalized directory names contain only lower case letters and digits. Fixes golang/go#44680 Change-Id: I4b710f90d1723c512e29dc3c248a1e681f1cd37f GitHub-Last-Rev: 8ae69f1c6fdf80831e5773bdb3507a8d51a4a0cf GitHub-Pull-Request: golang/tools#310 Reviewed-on: https://go-review.googlesource.com/c/tools/+/313092 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Peter Weinberger <pjw@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>		2021-04-27 19:53:45 +00:00
..
builtin.go	internal/lsp/completion: fix untyped int type inference	2021-02-05 20:20:24 +00:00
completion.go	lsp/completion: offer candidates converting arrays to slices	2021-04-22 04:15:51 +00:00
deep_completion.go	internal/lsp/source: handle nil pointer exception in completion	2020-11-14 22:40:30 +00:00
deep_completion_test.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
format.go	lsp/completion: offer candidates converting arrays to slices	2021-04-22 04:15:51 +00:00
keywords.go	internal/lsp/source/completion: remove "completion_" prefix from files	2020-10-30 17:45:15 +00:00
labels.go	internal/lsp/source/completion: remove "completion_" prefix from files	2020-10-30 17:45:15 +00:00
literal.go	internal/lsp/source/completion: add postfix snippet completions	2021-03-29 17:27:46 +00:00
package.go	internal/lsp/source/completion: suggest only valid package names	2021-04-27 19:53:45 +00:00
package_test.go	internal/lsp/source/completion: suggest only valid package names	2021-04-27 19:53:45 +00:00
postfix_snippets.go	lsp/completion: fix postfix completions preceding assignments	2021-04-26 15:26:58 +00:00
printf.go	internal/lsp: fix some incorrect spelling	2020-11-24 11:59:21 +00:00
printf_test.go	internal/lsp/source/completion: remove "completion_" prefix from files	2020-10-30 17:45:15 +00:00
snippet.go	internal/lsp/source/completion: remove "completion_" prefix from files	2020-10-30 17:45:15 +00:00
statements.go	internal/lsp: add snippet completion for t.Fatal errs	2021-03-15 21:39:02 +00:00
util.go	internal/lsp/source/completion: add postfix snippet completions	2021-03-29 17:27:46 +00:00
util_test.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00