go/src
Matteo Vaccari 9fcffc5359 net/http/pprof: avoid panic with user-defined "GET /" route
With the new routing style in go 1.22, declaring

    http.Handle("GET /", h)

generates a conflict with route "/debug/pprof/" and the others declared in
the net/http/pprof package. You get an error such as:

panic: pattern "GET /" (registered at .../pprof.go:94): GET / matches
fewer methods than /debug/pprof/, but has a more general path pattern

This patch prevents that error.  Adding GET is correct because no other
method makes sense with the /debug/pprof routes. However, a tool using any
method other than GET will break.

We preserve the traditional behaviour when GODEBUG=httpmuxgo121=1 is
specified.

Updates #65723

Change-Id: I49c21f5f3e802ad7538062d824354b2e4d8a800e
GitHub-Last-Rev: 35e4012663
GitHub-Pull-Request: golang/go#65791
Reviewed-on: https://go-review.googlesource.com/c/go/+/565176
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
2024-02-27 17:34:05 +00:00
..
archive archive/tar: check returned error before use hdr 2024-02-27 16:39:23 +00:00
arena
bufio
builtin builtin: mention PanicNilError in comments of recover 2023-12-18 19:42:41 +00:00
bytes strings: make use of sizeclasses in (*Builder).Grow 2024-02-19 19:51:15 +00:00
cmd cmd/internal, cmd/link: unify the relocation naming style of loong64 2024-02-27 17:26:07 +00:00
cmp cmp: add test case for uinitptr 2024-01-17 17:58:34 +00:00
compress
container container/heap: remove confusing claim of memory leak 2024-01-31 20:27:36 +00:00
context context: update doc comment to link to context interface 2024-02-17 23:25:55 +00:00
crypto crypto/tls: fix typo in comment 2024-02-26 21:34:41 +00:00
database/sql database/sql: wrap errors with %w in driverArgsConnLocked 2024-02-27 16:30:20 +00:00
debug debug/gosym: add detailed doc for text argument in NewLineTable 2024-01-25 19:43:24 +00:00
embed
encoding encoding/xml: remove unnecessary fmt.Sprintf call 2024-02-27 16:32:42 +00:00
errors
expvar expvar: avoid conflict with user-defined "GET /" route. 2024-02-26 15:31:33 +00:00
flag
fmt fmt: clear width and precision when recovering formatting object from the pool 2024-02-13 01:04:48 +00:00
go go/types: added test case for Checker.CheckExpr 2024-02-27 17:06:29 +00:00
hash Revert "hash/maphash: parallel run test" 2024-02-20 21:02:04 +00:00
html html/template: replace bytes.Compare call with bytes.Equal 2024-02-27 16:34:44 +00:00
image
index/suffixarray
internal path/filepath: add Localize 2024-02-26 18:08:14 +00:00
io io/fs: set ErrInvalid for FS.Open from SubFS when it fails ValidPath 2024-02-10 02:10:17 +00:00
iter iter: fix race instrumentation for Pull2 2023-12-13 16:20:09 +00:00
log log/slog: correct formatting 2024-02-20 20:44:14 +00:00
maps maps: correct use of linkname 2024-01-26 04:31:27 +00:00
math math: add round assembly implementations on riscv64 2024-02-23 08:34:12 +00:00
mime
net net/http/pprof: avoid panic with user-defined "GET /" route 2024-02-27 17:34:05 +00:00
os os: avoid GetFileInformationByHandleEx call when stat'ing files on Windows 2024-02-27 16:41:24 +00:00
path path/filepath: add Localize 2024-02-26 18:08:14 +00:00
plugin
reflect reflect: fix typo in comment 2024-02-27 16:41:16 +00:00
regexp regexp: add available godoc link 2024-02-26 20:50:01 +00:00
runtime std: fix more nilness findings 2024-02-26 22:01:11 +00:00
slices slices: document that BinarySearch[Func] return earliest position 2024-02-07 23:54:41 +00:00
sort sort: use math/rand/v2 in tests and benchmarks 2024-02-08 22:59:40 +00:00
strconv
strings strings: make use of sizeclasses in (*Builder).Grow 2024-02-19 19:51:15 +00:00
sync sync: add available godoc link 2024-02-26 20:48:55 +00:00
syscall syscall: fix typo in comment 2024-02-27 16:40:42 +00:00
testdata
testing testing/fstest: return base name from mapfs FileInfo.Name 2024-02-20 14:59:55 +00:00
text text: add available godoc link 2024-02-26 20:57:51 +00:00
time time: use bytealg.IndexByte in byteString 2024-02-26 20:46:01 +00:00
unicode
unsafe
vendor all: update golang.org/x/sys and vendor it 2024-02-08 20:35:26 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update golang.org/x/sys and vendor it 2024-02-08 20:35:26 +00:00
go.sum all: update golang.org/x/sys and vendor it 2024-02-08 20:35:26 +00:00
make.bash cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
make.bat cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
make.rc cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.