go/gopls/internal/regtest
Robert Findley 7424a4db47 internal/lsp/cache: fix check for excluded paths in locateTemplateFiles
The pathExcludedByFilter helper function expects path to be relative to
the workspace folder. This is a confusing API, and led to us passing
absolute paths when checking for excluded template files.

Fix it, add a regtest, and add a TODO to clean up the API.

Fixes golang/go#50431

Change-Id: Iedcf0dd9710e541c9fb8c296d9856a13ef3fbcb6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/378398
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-01-14 17:01:02 +00:00
..
bench gopls/internal/regtest: fix completion benchmarks 2021-08-12 16:12:36 +00:00
codelens gopls/internal/regtest/codelens: avoid compiler bug 2021-08-20 21:27:50 +00:00
completion gopls: add string join/split postfix completions 2022-01-11 13:55:59 +00:00
diagnostics gopls/internal/regtest/diagnostics: skip Test_Issue38211 2021-11-12 15:49:44 +00:00
misc gopls/internal/regtest: add regression tests for template diagnostics 2022-01-13 20:57:08 +00:00
modfile x/tools/gopls/internal/regtest/modfile: skip TestUnknownRevision and MultiModule tests on plan9 2022-01-07 05:33:44 +00:00
template internal/lsp/cache: fix check for excluded paths in locateTemplateFiles 2022-01-14 17:01:02 +00:00
watch gopls/internal/regtest: clean up TestFillReturnsPanic 2021-06-03 18:03:08 +00:00
workspace internal/lsp/cache: fix resolution of the go directive in multi-module 2021-11-19 19:11:45 +00:00