mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

x/tools/gopls/internal/regtest/modfile: skip TestUnknownRevision and MultiModule tests on plan9 

For golang/go#50477
For golang/go#50478

Change-Id: If2a9d175c06446db70628a21a1552e32239627c1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/375876
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Bryan C. Mills 2022-01-06 13:34:39 -05:00 committed by Bryan Mills
parent a1300ed2ba
commit 778a20b1a0
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gopls/internal/regtest/modfile/modfile_test.go
View File

@ -6,6 +6,7 @@ package modfile
import (
"path/filepath"
"runtime"
"strings"
"testing"
@ -513,6 +514,10 @@ require (
// Reproduces golang/go#38232.
func TestUnknownRevision(t *testing.T) {
if runtime.GOOS == "plan9" {
t.Skipf("skipping test that fails for unknown reasons on plan9; see https://go.dev/issue/50477")
}
testenv.NeedsGo1Point(t, 14)
const unknown = `

4
internal/lsp/tests/tests.go
View File

@ -16,6 +16,7 @@ import (
"os"
"path/filepath"
"regexp"
"runtime"
"sort"
"strconv"
"strings"
@ -273,6 +274,9 @@ func RunTests(t *testing.T, dataDir string, includeMultiModule bool, f func(*tes
if mode == "MultiModule" {
// Some bug in 1.12 breaks reading markers, and it's not worth figuring out.
testenv.NeedsGo1Point(t, 13)
if runtime.GOOS == "plan9" {
t.Skipf("MultiModule setup fails for undiagnosed reasons on plan9; see https://go.dev/issue/50478")
}
}
datum := load(t, mode, dataDir)
t.Helper()