Karthik Nayak 4fe0d6c80e internal/lsp: skip signature help within a string literal ... Currently the `SignatureHelp` function provides signature help even when the requested range lies within a string literal. Let's suppress this behavior and return an error when someone requests signature help from within a string literal. Fixes golang/go#43397 Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Change-Id: Ib03e87258622f4294bf9385bf5f0a8effe0050ee GitHub-Last-Rev: 0c9549ae68b0263a3cac274da133e9ab4b4c7bf5 GitHub-Pull-Request: golang/tools#332 Reviewed-on: https://go-review.googlesource.com/c/tools/+/337170 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com> Trust: Peter Weinberger <pjw@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>		2021-07-26 16:44:13 +00:00
..
analysisinternal	internal/lsp/fuzzy: fix return value on no match	2020-08-28 15:37:48 +00:00
apidiff	all: add copyright notices to files that are missing them	2021-01-06 17:23:47 +00:00
event	internal/lsp/debug: add a facility to track known bugs	2021-05-10 23:21:19 +00:00
fakenet	internal/fakenet: add a fake network connection	2020-05-27 14:27:59 +00:00
fastwalk	x/tools/internal/fastwalk: fixes "interrupted system call" error	2021-02-24 01:32:32 +00:00
gocommand	internal/gocommand: run 'go list' on the unsafe package when fetching release tags	2021-05-29 00:21:43 +00:00
gopathwalk	internal/imports: fix crash when adding stdlib imports	2020-08-13 17:47:04 +00:00
imports	go/packages/packagestest: make Export skip tests involving unsupported links	2021-06-02 19:23:16 +00:00
jsonrpc2	internal/jsonrpc2: remove unused invalidID constant	2021-02-04 15:49:51 +00:00
jsonrpc2_v2	internal/lsp/lsprpc: update binder tests to handle forwarding	2021-06-25 19:21:47 +00:00
lsp	internal/lsp: skip signature help within a string literal	2021-07-26 16:44:13 +00:00
memoize	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
mod	internal/mod: add workfile parser	2021-06-24 04:20:08 +00:00
packagesinternal	internal/lsp/cache: disable network for mod tidy diagnostics	2021-02-05 19:41:14 +00:00
proxydir	all: remove version-specific test files	2020-05-28 17:13:50 +00:00
span	internal/span: compute utf16 length directly	2021-05-20 14:08:36 +00:00
stack	internal/stack: add the leak test	2020-05-27 14:25:42 +00:00
testenv	internal/testenv: actually Exit if small machine for netbsd-arm*-bsiegert	2021-06-25 23:53:21 +00:00
tool	internal/lsp/cmd: print flags when running gopls help	2021-07-08 16:04:41 +00:00
typeparams	go/ast/astutil: fix panic when rewriting multi-argument type instances	2021-06-09 21:40:20 +00:00
typesinternal	internal/typesinternal: sync error codes with go1.16	2021-02-16 20:01:04 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00