The Go programming language
Go to file
Karthik Nayak 4fe0d6c80e internal/lsp: skip signature help within a string literal
Currently the `SignatureHelp` function provides signature help even when the
requested range lies within a string literal. Let's suppress this behavior and
return an error when someone requests signature help from within a string
literal.

Fixes golang/go#43397

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

Change-Id: Ib03e87258622f4294bf9385bf5f0a8effe0050ee
GitHub-Last-Rev: 0c9549ae68b0263a3cac274da133e9ab4b4c7bf5
GitHub-Pull-Request: golang/tools#332
Reviewed-on: https://go-review.googlesource.com/c/tools/+/337170
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Robert Findley <rfindley@google.com>
Trust: Peter Weinberger <pjw@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-07-26 16:44:13 +00:00
benchmark/parse benchmark/parse: add unit test for String function 2019-12-16 21:43:19 +00:00
blog copyright: test that all files in the repo have copyright notices 2021-01-11 22:19:46 +00:00
cmd cmd/getgo: determine current version via /dl/?mode=json API 2021-06-07 15:22:48 +00:00
container/intsets all: go fmt ./... 2021-02-20 03:28:52 +00:00
copyright copyright: test that all files in the repo have copyright notices 2021-01-11 22:19:46 +00:00
cover cover: fix sorting of profile segment boundaries 2020-09-16 14:01:29 +00:00
go all: add SliceToArrayPointer instruction 2021-07-21 23:55:41 +00:00
godoc godoc/static: add gopher/pkg.png image 2021-05-07 20:56:39 +00:00
gopls internal/lsp/source: evaluate bin/hex literal on hover 2021-07-26 16:25:21 +00:00
imports all: add copyright notices to files that are missing them 2021-01-06 17:23:47 +00:00
internal internal/lsp: skip signature help within a string literal 2021-07-26 16:44:13 +00:00
playground playground: remove /share registration, add Proxy 2021-02-25 15:03:53 +00:00
present present: don't drop commands that immediately follow text 2021-03-19 17:28:02 +00:00
refactor all: go fmt ./... 2021-02-20 03:28:52 +00:00
txtar txtar: minor fix in unit test input 2021-02-18 20:23:11 +00:00
.gitattributes
.gitignore
.prettierrc all: add a section on JS/CSS formatting to README 2020-05-28 15:31:34 +00:00
AUTHORS
CONTRIBUTING.md CONTRIBUTING.md: remove note about not accepting Pull Requests 2018-03-14 18:02:17 +00:00
CONTRIBUTORS
LICENSE
PATENTS
README.md tools, gopls: add pkg.go.dev badges to READMEs 2020-12-03 23:01:54 +00:00
codereview.cfg
go.mod all: update all dependencies except for sergi/go-diff and golang.org/x/net 2021-05-11 14:29:16 +00:00
go.sum all: update all dependencies except for sergi/go-diff and golang.org/x/net 2021-05-11 14:29:16 +00:00

README.md

Go Tools

PkgGoDev

This subrepository holds the source for various packages and tools that support the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.

Others, including the Go guru and the test coverage tool, can be fetched with go get.

Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.

Download/Install

The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.

JS/CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.