mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

internal/lsp/source: fix ranking of untyped completions 

Claiming that untyped candidates matched the type of whatever we were
looking for messed up rankings in found(). The only other places that
use it will all work better with false. Return false.

Updates golang/go#36591.

Change-Id: I5e1e8af7cc5c27422740cbb77f9a4a20edb1e447
Reviewed-on: https://go-review.googlesource.com/c/tools/+/215322
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Heschi Kreinick 2020-01-17 16:20:39 -05:00
parent 1486df0b25
commit fe56e63357
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/lsp/source/completion.go
View File

@ -1695,7 +1695,7 @@ func (c *completer) matchingCandidate(cand *candidate) bool {
candType := cand.obj.Type()
if candType == nil {
return true
return false
}
// Default to invoking *types.Func candidates. This is so function