From fe56e63357632a74e1c5d77333b471aa69997fd6 Mon Sep 17 00:00:00 2001 From: Heschi Kreinick Date: Fri, 17 Jan 2020 16:20:39 -0500 Subject: [PATCH] internal/lsp/source: fix ranking of untyped completions Claiming that untyped candidates matched the type of whatever we were looking for messed up rankings in found(). The only other places that use it will all work better with false. Return false. Updates golang/go#36591. Change-Id: I5e1e8af7cc5c27422740cbb77f9a4a20edb1e447 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215322 Reviewed-by: Rebecca Stambler --- internal/lsp/source/completion.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/lsp/source/completion.go b/internal/lsp/source/completion.go index 7039ab5a7c..6eb56c973a 100644 --- a/internal/lsp/source/completion.go +++ b/internal/lsp/source/completion.go @@ -1695,7 +1695,7 @@ func (c *completer) matchingCandidate(cand *candidate) bool { candType := cand.obj.Type() if candType == nil { - return true + return false } // Default to invoking *types.Func candidates. This is so function