mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

go/packages: fix compatibility with gopackagesdriver 

The Mode field is part of an RPC interface with gopackagesdriver
implementations, so renumbering the Need bits by adding a new value in
the middle is a compatibility break. Move it to the bottom.

Also update an incorrect comment.

Change-Id: Idad9e9e8b163f3b516ff9055d503af8749dd343c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/234099
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Heschi Kreinick 2020-05-14 16:58:57 -04:00
parent d5fe73897c
commit d0dc4d41b7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
go/packages/packages.go
View File

@ -50,10 +50,6 @@ const (
// NeedCompiledGoFiles adds CompiledGoFiles.
NeedCompiledGoFiles
// TypecheckCgo enables full support for type checking cgo. Requires Go 1.15+.
// Has no effect without NeedTypes.
TypecheckCgo
// NeedImports adds Imports. If NeedDeps is not set, the Imports field will contain
// "placeholder" Packages with only the ID set.
NeedImports
@ -75,6 +71,10 @@ const (
// NeedTypesSizes adds TypesSizes.
NeedTypesSizes
// TypecheckCgo enables full support for type checking cgo. Requires Go 1.15+.
// Modifies CompiledGoFiles and Types, and has no effect on its own.
TypecheckCgo
)
const (