From d0dc4d41b76d4ee7dd9784e6c7e2d420537efb28 Mon Sep 17 00:00:00 2001 From: Heschi Kreinick Date: Thu, 14 May 2020 16:58:57 -0400 Subject: [PATCH] go/packages: fix compatibility with gopackagesdriver The Mode field is part of an RPC interface with gopackagesdriver implementations, so renumbering the Need bits by adding a new value in the middle is a compatibility break. Move it to the bottom. Also update an incorrect comment. Change-Id: Idad9e9e8b163f3b516ff9055d503af8749dd343c Reviewed-on: https://go-review.googlesource.com/c/tools/+/234099 Run-TryBot: Heschi Kreinick Reviewed-by: Rebecca Stambler TryBot-Result: Gobot Gobot --- go/packages/packages.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/go/packages/packages.go b/go/packages/packages.go index 1df46ccccf..68039d3a9d 100644 --- a/go/packages/packages.go +++ b/go/packages/packages.go @@ -50,10 +50,6 @@ const ( // NeedCompiledGoFiles adds CompiledGoFiles. NeedCompiledGoFiles - // TypecheckCgo enables full support for type checking cgo. Requires Go 1.15+. - // Has no effect without NeedTypes. - TypecheckCgo - // NeedImports adds Imports. If NeedDeps is not set, the Imports field will contain // "placeholder" Packages with only the ID set. NeedImports @@ -75,6 +71,10 @@ const ( // NeedTypesSizes adds TypesSizes. NeedTypesSizes + + // TypecheckCgo enables full support for type checking cgo. Requires Go 1.15+. + // Modifies CompiledGoFiles and Types, and has no effect on its own. + TypecheckCgo ) const (