From 778a20b1a0da3db0de0835df6587ec4e101215cc Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Thu, 6 Jan 2022 13:34:39 -0500 Subject: [PATCH] x/tools/gopls/internal/regtest/modfile: skip TestUnknownRevision and MultiModule tests on plan9 For golang/go#50477 For golang/go#50478 Change-Id: If2a9d175c06446db70628a21a1552e32239627c1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/375876 Trust: Bryan Mills Run-TryBot: Bryan Mills gopls-CI: kokoro Reviewed-by: Robert Findley --- gopls/internal/regtest/modfile/modfile_test.go | 5 +++++ internal/lsp/tests/tests.go | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/gopls/internal/regtest/modfile/modfile_test.go b/gopls/internal/regtest/modfile/modfile_test.go index 6c94bfb464..8592a96dc9 100644 --- a/gopls/internal/regtest/modfile/modfile_test.go +++ b/gopls/internal/regtest/modfile/modfile_test.go @@ -6,6 +6,7 @@ package modfile import ( "path/filepath" + "runtime" "strings" "testing" @@ -513,6 +514,10 @@ require ( // Reproduces golang/go#38232. func TestUnknownRevision(t *testing.T) { + if runtime.GOOS == "plan9" { + t.Skipf("skipping test that fails for unknown reasons on plan9; see https://go.dev/issue/50477") + } + testenv.NeedsGo1Point(t, 14) const unknown = ` diff --git a/internal/lsp/tests/tests.go b/internal/lsp/tests/tests.go index 45d3ccd052..2589e77f41 100644 --- a/internal/lsp/tests/tests.go +++ b/internal/lsp/tests/tests.go @@ -16,6 +16,7 @@ import ( "os" "path/filepath" "regexp" + "runtime" "sort" "strconv" "strings" @@ -273,6 +274,9 @@ func RunTests(t *testing.T, dataDir string, includeMultiModule bool, f func(*tes if mode == "MultiModule" { // Some bug in 1.12 breaks reading markers, and it's not worth figuring out. testenv.NeedsGo1Point(t, 13) + if runtime.GOOS == "plan9" { + t.Skipf("MultiModule setup fails for undiagnosed reasons on plan9; see https://go.dev/issue/50478") + } } datum := load(t, mode, dataDir) t.Helper()