From afbbeadf08aa5ab01a9956aa14398a0563762bc0 Mon Sep 17 00:00:00 2001 From: Cory Benfield Date: Tue, 18 Jun 2019 14:31:48 +0100 Subject: [PATCH] Handle .url endpoint in switches over endpoint. (#48) Motivation: macOS Catalina brings a .url endpoint to Network.framework, which is currently causing build warnings. We should tolerate it and silence those warnings. Modifications: Do the right thing when we receive a .url endpoint. Result: No build warnings. --- Sources/NIOTransportServices/NIOTSListenerChannel.swift | 2 ++ Sources/NIOTransportServices/SocketAddress+NWEndpoint.swift | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Sources/NIOTransportServices/NIOTSListenerChannel.swift b/Sources/NIOTransportServices/NIOTSListenerChannel.swift index 067c606..083f40a 100644 --- a/Sources/NIOTransportServices/NIOTSListenerChannel.swift +++ b/Sources/NIOTransportServices/NIOTSListenerChannel.swift @@ -301,6 +301,8 @@ extension NIOTSListenerChannel: StateManagedChannel { parameters.requiredLocalEndpoint = target case .service(_, _, _, let interface): parameters.requiredInterface = interface + case .url: + break @unknown default: () } diff --git a/Sources/NIOTransportServices/SocketAddress+NWEndpoint.swift b/Sources/NIOTransportServices/SocketAddress+NWEndpoint.swift index 16467c4..a32a963 100644 --- a/Sources/NIOTransportServices/SocketAddress+NWEndpoint.swift +++ b/Sources/NIOTransportServices/SocketAddress+NWEndpoint.swift @@ -100,9 +100,7 @@ extension SocketAddress { self = .init(addr, host: host.debugDescription) case .unix(let path): self = try .init(unixDomainSocketPath: path) - case .service: - throw NIOTSErrors.UnableToResolveEndpoint() - case .hostPort(_, _): + case .service, .hostPort, .url: throw NIOTSErrors.UnableToResolveEndpoint() @unknown default: throw NIOTSErrors.UnableToResolveEndpoint()