Remove unnecessary traps. (#37)
Motivation: At least in some cases it's possible to have a local or remote address that we cannot represent in a SocketAddress. In the face of that, we were unnecessarily crashing. Crashes should probably be avoided there. Modifications: - Replace the crashes with throws. Result: Fewer crashes, more nils.
This commit is contained in:
parent
442e1807df
commit
687e79828a
|
|
@ -97,11 +97,11 @@ extension SocketAddress {
|
||||||
case .unix(let path):
|
case .unix(let path):
|
||||||
self = try .init(unixDomainSocketPath: path)
|
self = try .init(unixDomainSocketPath: path)
|
||||||
case .service:
|
case .service:
|
||||||
preconditionFailure("Cannot represent service addresses in SocketAddress")
|
throw NIOTSErrors.UnableToResolveEndpoint()
|
||||||
case .hostPort(_, _):
|
case .hostPort(_, _):
|
||||||
preconditionFailure("Cannot represent unknown host in SocketAddress")
|
throw NIOTSErrors.UnableToResolveEndpoint()
|
||||||
@unknown default:
|
@unknown default:
|
||||||
preconditionFailure("cannot create SocketAddress from unknown representation")
|
throw NIOTSErrors.UnableToResolveEndpoint()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue