mirror
/
swift-nio-transport-services
mirror of https://github.com/apple/swift-nio-transport-services.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enable TCP_NODELAY by default. (#46) 

Motivation:

Networking software like SwiftNIO that always has explicit flushes
usually does not benefit from having TCP_NODELAY switched off. The
benefits of having it turned on are usually quite substantial and yet we
forced our users for the longest time to enable it manually.

Quite a bit of engineering time has been lost finding performance
problems and it turns out switching TCP_NODELAY on solves them
magically.

Netty has made the switch to TCP_NODELAY on by default, SwiftNIO should
follow. This patch is the equivalent of apple/swift-nio#1020.

Modifications:

Enable TCP_NODELAY by default.

Result:

If the user forgot to enable TCP_NODELAY, their software should now be
faster.
This commit is contained in:
Cory Benfield 2019-06-18 14:27:20 +01:00 committed by GitHub
parent b0b3ba5e7f
commit 4d8fb8e887
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Sources/NIOTransportServices/NIOTSConnectionBootstrap.swift
View File

@ -35,6 +35,8 @@ public final class NIOTSConnectionBootstrap {
/// - group: The `NIOTSEventLoopGroup` to use.
public init(group: NIOTSEventLoopGroup) {
self.group = group
self.channelOptions.append(key: ChannelOptions.socket(IPPROTO_TCP, TCP_NODELAY), value: 1)
}
/// Initialize the connected `NIOTSConnectionChannel` with `initializer`. The most common task in initializer is to add

6
Sources/NIOTransportServices/NIOTSListenerBootstrap.swift
View File

@ -38,6 +38,9 @@ public final class NIOTSListenerBootstrap {
/// - group: The `EventLoopGroup` to use for the `ServerSocketChannel`.
public convenience init(group: NIOTSEventLoopGroup) {
self.init(group: group, childGroup: group)
self.serverChannelOptions.append(key: ChannelOptions.socket(IPPROTO_TCP, TCP_NODELAY), value: 1)
self.childChannelOptions.append(key: ChannelOptions.socket(IPPROTO_TCP, TCP_NODELAY), value: 1)
}
/// Create a `NIOTSListenerBootstrap`.
@ -49,6 +52,9 @@ public final class NIOTSListenerBootstrap {
public init(group: NIOTSEventLoopGroup, childGroup: NIOTSEventLoopGroup) {
self.group = group
self.childGroup = childGroup
self.serverChannelOptions.append(key: ChannelOptions.socket(IPPROTO_TCP, TCP_NODELAY), value: 1)
self.childChannelOptions.append(key: ChannelOptions.socket(IPPROTO_TCP, TCP_NODELAY), value: 1)
}
/// Initialize the `NIOTSListenerChannel` with `initializer`. The most common task in initializer is to add

2
Tests/NIOTransportServicesTests/NIOTSSocketOptionsOnChannelTests.swift
View File

@ -76,7 +76,7 @@ class NIOTSSocketOptionsOnChannelTests: XCTestCase {
}
func testNODELAY() throws {
try self.assertChannelOptionAfterCreation(option: SocketOption(level: IPPROTO_TCP, name: TCP_NODELAY), initialValue: 0, testAlternativeValue: 1)
try self.assertChannelOptionAfterCreation(option: SocketOption(level: IPPROTO_TCP, name: TCP_NODELAY), initialValue: 1, testAlternativeValue: 0)
}
func testNOPUSH() throws {