From 86391ad9112f5695b780c92e76c42ae519ee108b Mon Sep 17 00:00:00 2001 From: Hamzah Malik Date: Fri, 26 May 2023 13:29:43 +0100 Subject: [PATCH] Rename retrieveValueInPreferredUnit to valueInPreferredUnit --- Sources/MetricsTestKit/TestMetrics.swift | 2 +- Tests/MetricsTests/CoreMetricsTests.swift | 2 +- Tests/MetricsTests/MetricsTests.swift | 14 +++++++------- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Sources/MetricsTestKit/TestMetrics.swift b/Sources/MetricsTestKit/TestMetrics.swift index f1c4db5..28b045e 100644 --- a/Sources/MetricsTestKit/TestMetrics.swift +++ b/Sources/MetricsTestKit/TestMetrics.swift @@ -492,7 +492,7 @@ public final class TestTimer: TestMetric, TimerHandler, Equatable { } } - public func retrieveValueInPreferredUnit(atIndex i: Int) -> Double { + public func valueInPreferredUnit(atIndex i: Int) -> Double { let value = self.values[i] guard let displayUnit = self.displayUnit else { return Double(value) diff --git a/Tests/MetricsTests/CoreMetricsTests.swift b/Tests/MetricsTests/CoreMetricsTests.swift index 6edce53..de5c98e 100644 --- a/Tests/MetricsTests/CoreMetricsTests.swift +++ b/Tests/MetricsTests/CoreMetricsTests.swift @@ -460,7 +460,7 @@ class MetricsTests: XCTestCase { XCTAssertEqual(timer?.values.count, 1, "expected number of entries to match") XCTAssertEqual(timer?.values[0], Int64(seconds * 1_000_000_000), "expected value to match") XCTAssertEqual(timer?.displayUnit, .minutes, "expected value to match") - XCTAssertEqual(timer?.retrieveValueInPreferredUnit(atIndex: 0), Double(seconds) / 60.0, "seconds should be returned as minutes") + XCTAssertEqual(timer?.valueInPreferredUnit(atIndex: 0), Double(seconds) / 60.0, "seconds should be returned as minutes") } } diff --git a/Tests/MetricsTests/MetricsTests.swift b/Tests/MetricsTests/MetricsTests.swift index fc2d2d5..9c12bae 100644 --- a/Tests/MetricsTests/MetricsTests.swift +++ b/Tests/MetricsTests/MetricsTests.swift @@ -132,25 +132,25 @@ class MetricsExtensionsTests: XCTestCase { let testTimer = timer._handler as! TestTimer testTimer.preferDisplayUnit(.nanoseconds) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value * 1000 * 1000 * 1000, accuracy: 1.0, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value * 1000 * 1000 * 1000, accuracy: 1.0, "expected value to match") testTimer.preferDisplayUnit(.microseconds) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value * 1000 * 1000, accuracy: 0.001, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value * 1000 * 1000, accuracy: 0.001, "expected value to match") testTimer.preferDisplayUnit(.milliseconds) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value * 1000, accuracy: 0.000001, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value * 1000, accuracy: 0.000001, "expected value to match") testTimer.preferDisplayUnit(.seconds) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value, accuracy: 0.000000001, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value, accuracy: 0.000000001, "expected value to match") testTimer.preferDisplayUnit(.minutes) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value / 60, accuracy: 0.000000001, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value / 60, accuracy: 0.000000001, "expected value to match") testTimer.preferDisplayUnit(.hours) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value / (60 * 60), accuracy: 0.000000001, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value / (60 * 60), accuracy: 0.000000001, "expected value to match") testTimer.preferDisplayUnit(.days) - XCTAssertEqual(testTimer.retrieveValueInPreferredUnit(atIndex: 0), value / (60 * 60 * 24), accuracy: 0.000000001, "expected value to match") + XCTAssertEqual(testTimer.valueInPreferredUnit(atIndex: 0), value / (60 * 60 * 24), accuracy: 0.000000001, "expected value to match") } }