mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
rustc-dev-guide/src
History
Matthias Krüger 7ceeee7ca4
Rollup merge of #138533 - Kobzol:try-job-auto-tests, r=marcoieni 
Only use `DIST_TRY_BUILD` for try jobs that were not selected explicitly

Some CI jobs (x64 Linux, ARM64 Linux and x64 MSVC) use the `opt-dist` tool to build an optimized toolchain using PGO and BOLT. When performing a default try build for x64 Linux, in most cases we want to run perf. on that artifact. To reduce the latency of this common use-case, `opt-dist` skips building several components not needed for perf., and it also skips running post-optimization tests, when it detects that the job is executed as a try job (not a merge/auto job).

This is useful, but it also means that if you *want* to run the tests, you had to go to `jobs.yml` and manually comment this environment variable, create a WIP commit, do a try build, and then remove the WIP commit, which is annoying (in the similar way that modifying what gets run in try builds was annoying before we had the `try-job` annotations).

I thought that we could introduce some additional PR description marker like `try-job-run-tests`, but it's hard to discover that such things exist.

Instead, I think that there's a much simpler heuristic for determining whether `DIST_TRY_BUILD` should be used (that I implemented in this PR):
- If you do just ``@bors` try`, without any custom try jobs selected, `DIST_TRY_BUILD` will be activated, to finish the build as fast as possible.
- If you specify any custom try jobs, you are most likely doing experiments and you want to see if tests pass and everything builds as it should. The `DIST_TRY_BUILD` variable will thus *not* be set in this case.

In this way, if you want to run dist tests, you can just add the `try-job: dist-x86_64-linux` line to the PR description, and you don't need to create any WIP commits.

r? `@marcoieni`
 		2025-03-17 22:49:06 +01:00
..
appendix Replace link with a https based one 2025-02-06 09:12:42 +01:00
backend replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
borrow_check nyaa 2025-01-15 14:23:48 +01:00
building replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
const-eval Fix more links (#1884) 2024-02-21 12:17:28 -03:00
diagnostics tree-wide: parallel: Fully removed all `Lrc`, replaced with `Arc` 2025-02-03 13:25:57 +03:00
guides Fix some broken links 2025-01-14 21:52:33 -08:00
img Remove outdated references to coverage debug code (#1797) 2023-09-22 01:32:45 +09:00
mir intern valtrees 2025-02-13 00:38:17 +01:00
notification-groups Use `id` attribute for `<a>` tags instead of deprecated `name` attribute (#2184) 2024-12-31 22:02:50 +08:00
param_env Remove reference to enum.Reveal 2025-02-07 09:03:22 +01:00
profiling replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
queries Use `id` attribute for `<a>` tags instead of deprecated `name` attribute (#2184) 2024-12-31 22:02:50 +08:00
rustc-driver Fix examples to work with nightly-2025-02-13 2025-02-15 19:44:32 +01:00
rustdoc-internals Update links to type schemas 2025-02-06 08:29:10 -07:00
solve Fix grammar and remove redundant info 2025-03-13 23:56:04 +01:00
tests Rollup merge of #138533 - Kobzol:try-job-auto-tests, r=marcoieni 2025-03-17 22:49:06 +01:00
traits Apply suggestions from code review 2025-02-02 17:30:30 +09:00
ty_module fix some more typos 2025-01-14 23:01:42 -08:00
SUMMARY.md Merge pull request #2258 from fee1-dead-contrib/constck 2025-03-10 12:35:40 +01:00
about-this-guide.md Update about-this-guide.md 2025-01-28 07:43:16 +01:00
asm.md Fix some typos 2024-12-18 07:56:30 +02:00
ast-lowering.md Rename AstConv to HIR ty lowering 2024-03-23 08:44:42 +01:00
ast-validation.md Fix Typo and Remove Outdated Line About C Variadics 2024-09-10 09:32:10 +02:00
attributes.md Document inert vs active attributes (#1110) 2024-06-23 16:09:09 +02:00
borrow_check.md
…
bug-fix-procedure.md Fix broken raw HTML (#2198) 2025-01-07 16:00:59 +08:00
cli.md
…
closure.md fix some more typos 2025-01-14 23:01:42 -08:00
coherence.md Fix some typos 2024-12-18 07:56:30 +02:00
compiler-debugging.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
compiler-src.md Fix internal and incomplete links (#2107) 2024-10-31 11:13:57 +08:00
compiler-team.md Replace experts map with reviewers from triagebot 2023-12-05 18:40:26 +02:00
const-eval.md fix some more typos 2025-01-14 23:01:42 -08:00
contributing.md Only keep label description in Forge docs 2025-01-06 18:59:36 +02:00
conventions.md Fix a typo in conventions.md 2025-01-31 10:23:46 +11:00
coroutine-closures.md Ok now linkify 2024-11-02 16:45:00 -04:00
crates-io.md
…
debugging-support-in-rustc.md fix: stabilize debugger_visualizer 2023-08-14 10:34:59 +02:00
diagnostics.md overlong line 2025-02-03 22:07:10 +02:00
early_late_parameters.md Remove accidental leading empty line in code block 2025-01-26 02:42:09 +01:00
effects.md consider `explicit_implied_const_bounds` 2025-03-08 16:38:44 +08:00
external-repos.md Add portable SIMD to list of subtrees 2025-01-20 13:53:10 +01:00
feature-gate-ck.md
…
feature-gates.md Remove feature edition fields. (#1836) 2023-12-13 21:19:43 +09:00
fuzzing.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
generic_parameters_summary.md Split stuff out of representing types, and rewrite early/late bound chapter (#2192) 2025-01-05 17:51:45 +01:00
getting-started.md Remove "Port run-make tests from Make to Rust" tracking issue from Recurring work 2025-02-04 01:26:15 +05:30
git.md squashing: recommend --keep-base when squashing without a conflict (#2157) 2024-12-07 06:59:23 +08:00
hir-debugging.md recommend `unpretty=hir` alongside `unpretty=hir-tree` 2023-10-18 10:01:49 -07:00
hir.md Move methods from `Map` to `TyCtxt`, part 4. 2025-03-12 08:55:37 +11:00
implementing_new_features.md docs(dev): Access features as functions, not members 2025-02-18 10:35:13 -06:00
incrcomp-debugging.md Followup to #1862 (#1864) 2024-01-28 06:12:41 +09:00
lang-items.md
…
licenses.md chore: fix some comments 2024-07-30 08:04:13 +02:00
llvm-coverage-instrumentation.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
macro-expansion.md Minor edits 2024-09-24 20:16:28 +02:00
memory.md Fix broken links (#2123) 2024-11-04 16:24:05 +08:00
method-lookup.md comment out FIXMEs to not display them on UI (#2186) 2025-01-05 17:51:45 +01:00
name-resolution.md Minor edits 2024-09-24 20:07:57 +02:00
opaque-types-impl-trait-inference.md fix some more typos 2025-01-14 23:01:42 -08:00
opaque-types-type-alias-impl-trait.md
…
overview.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
panic-implementation.md separate link target from normal content 2024-02-11 06:36:15 +01:00
parallel-rustc.md Remove some unnecessary aliases from `rustc_data_structures::sync` 2025-03-03 20:20:24 +11:00
part-2-intro.md refactor(parts): remove part numbers to be consistent 2023-08-11 09:55:19 +02:00
part-3-intro.md refactor(parts): remove part numbers to be consistent 2023-08-11 09:55:19 +02:00
part-4-intro.md refactor(parts): remove part numbers to be consistent 2023-08-11 09:55:19 +02:00
part-5-intro.md revert(part-5-intro): revert 4806958 2023-08-11 09:55:19 +02:00
pat-exhaustive-checking.md Fix some typos 2024-12-18 07:56:30 +02:00
profile-guided-optimization.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
profiling.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
query.md Fix some links 2023-06-29 06:43:19 +02:00
return-position-impl-trait-in-trait.md fix some typos 2024-05-21 11:56:12 +02:00
rustbot.md Add some explanations for frequently used rustbot commands (#1849) 2024-01-20 19:56:35 +08:00
rustdoc-internals.md Fix rustc-related links that are 404 right now (#2112) 2024-11-02 20:53:31 +08:00
rustdoc.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
sanitizers.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
serialization.md minor edits 2024-09-24 20:33:04 +02:00
stability.md rustc-dev-guide: add note about not adding rustc_allowed_through_unstable_modules to more items 2025-01-14 17:00:12 +01:00
stabilization_guide.md Use `id` attribute for `<a>` tags instead of deprecated `name` attribute (#2184) 2024-12-31 22:02:50 +08:00
syntax-intro.md Fix internal and incomplete links (#2107) 2024-10-31 11:13:57 +08:00
test-implementation.md Document inert vs active attributes (#1110) 2024-06-23 16:09:09 +02:00
the-parser.md Fix some broken links 2025-01-14 21:52:33 -08:00
thir.md Fix rustc-related links that are 404 right now (#2112) 2024-11-02 20:53:31 +08:00
tracing.md replace config.toml to bootstrap.toml in src:doc:rustc-dev-guide 2025-03-17 12:56:44 +05:30
ty-fold.md linkcheck: fix reported broken links (part 2) (#2024) 2024-07-27 14:45:57 +02:00
ty.md Flatten generic parameter defs section 2024-11-22 11:17:57 +00:00
type-checking.md
…
type-inference.md Use `id` attribute for `<a>` tags instead of deprecated `name` attribute (#2184) 2024-12-31 22:02:50 +08:00
unsafety-checking.md Fix more links (#1884) 2024-02-21 12:17:28 -03:00
variance.md Use `id` attribute for `<a>` tags instead of deprecated `name` attribute (#2184) 2024-12-31 22:02:50 +08:00
walkthrough.md Use `id` attribute for `<a>` tags instead of deprecated `name` attribute (#2184) 2024-12-31 22:02:50 +08:00