Commit Graph

2731 Commits

Author SHA1 Message Date
The rustc-dev-guide Cronjob Bot ee03ec2984 Merge from rustc 2025-06-12 04:06:44 +00:00
Matthias Krüger 87514bfa86
Rollup merge of #142297 - jieyouxu:needs-target-std, r=Kobzol
Implement `//@ needs-target-std` compiletest directive

Closes rust-lang/rust#141863.
Needed to unblock rust-lang/rust#139244 and rust-lang/rust#141856.

### Summary

This PR implements a `//@ needs-target-std` compiletest directive that gates test execution based on whether the target supports std or not. For some cases, this should be preferred over e.g. some combination of `//@ ignore-none`, `//@ ignore-nvptx` and more[^none-limit].

### Implementation limitation

Unfortunately, since there is currently [no reliable way to determine from metadata whether a given target supports std or not](https://github.com/rust-lang/rust/issues/142296), we have to resort to a hack. Bootstrap currently determines whether or not a target supports std by a naive target tuple substring comparison: a target supports std if its target tuple does *not* contain one of `["-none", "nvptx", "switch"]` substrings. This PR simply pulls that hack out into `build_helpers` to avoid reimplementing the same hack in compiletest, and uses that logic to inform `//@ needs-target-std`.

### Auxiliary changes

This PR additionally changes a few run-make tests to use `//@ needs-target-std` over an inconsistent combination of target-based `ignore`s. This should help with rust-lang/rust#139244.

---

r? bootstrap

[^none-limit]: Notably, `target_os = "none"` is **not** a sufficient condition for "target does not support std"
2025-06-11 13:48:11 +02:00
Tshepang Mbambo 23604cd1a3
that was phrased like a separate sentence 2025-06-11 07:14:12 +02:00
lolbinarycat aa0516b863
Using git § I changed a submodule by accident: be explicit
Rewriting git history is something that is often difficult for new contributors,
and we're already explaining the `<foo>` placeholder syntax,
so I think it makes sense to be explicit about what exactly the paths mean.
2025-06-10 12:48:05 -05:00
Jieyou Xu b8b2ca49e0
Document `//@ needs-target-std` in rustc-dev-guide 2025-06-10 22:17:57 +08:00
The rustc-dev-guide Cronjob Bot 4cc3df21eb Merge from rustc 2025-06-09 04:09:17 +00:00
cyrgani ea2377504f remove the archived ICE ping groups 2025-06-08 21:49:54 +02:00
León Orell Valerian Liehr 3eb40c40b7
Fix typo 2025-06-07 18:58:41 +02:00
León Orell Valerian Liehr 99626a308d
Merge pull request #2298 from fmease/rustdoc-testing-addendum
rustdoc: Further improve chapters and sections on testing
2025-06-07 18:36:45 +02:00
León Orell Valerian Liehr f5e1a73fb5
rustdoc: Further improve chapters and sections on testing 2025-06-07 18:35:40 +02:00
Matthias Krüger 0c371e20ad
Rollup merge of #141970 - onur-ozkan:skip-stage1-std, r=Kobzol
implement new `x` flag: `--skip-std-check-if-no-download-rustc`

One of our developers (``@RalfJung)`` [reported](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Surprising.20stages.20for.20check.20build.20after.20stage.20reorg/with/521925606)[#t-infra/bootstrap > Surprising stages for check build after stage reorg](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Surprising.20stages.20for.20check.20build.20after.20stage.20reorg/with/521925606) that working on both the compiler and the library simultaneously with RA enabled is extremely difficult because checking library creates a heavy load on machines (by building stage1 compiler) on each modification. `--skip-std-check-if-no-download-rustc` flag is intended to reduce this heavy load on their IDE integration as much as possible.

Fixes: rust-lang/rust#141955
2025-06-05 12:21:34 +02:00
onur-ozkan cda721a97f document `skip-std-check-if-no-download-rustc` in rustc-dev-guide
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2025-06-04 15:23:58 +03:00
许杰友 Jieyou Xu (Joe) 90529c8e54
Merge pull request #2454 from rust-lang/tshepang-expand 2025-06-04 16:46:11 +08:00
Rageking8 9120682212
Fix incorrect use of "recommend" over "recommended" 2025-06-04 16:30:02 +08:00
Tshepang Mbambo d159211d5c expand meaning of ~? diagnostic annotation 2025-06-04 00:26:47 +02:00
Jieyou Xu 88e0085b00 Merge from rustc 2025-06-03 20:17:50 +08:00
Tshepang Mbambo 1d8f15e1f7
Merge pull request #2443 from smanilov/patch-21
Simplify long sentence
2025-06-02 17:30:02 +02:00
Stan Manilov c58ec21749 Simplify long sentence 2025-06-02 17:52:34 +03:00
León Orell Valerian Liehr 16525780ff
Merge pull request #2446 from fmease/fix-warning-blocks
Fix some warning blocks that contain Markdown
2025-06-02 16:27:47 +02:00
León Orell Valerian Liehr 6e608e5671
Fix some warning blocks that contain Markdown
Contents inside of an HTML element only get interpreted as Markdown
(as opposed to HTML) if its separated from the HTML tags with line breaks.
2025-06-02 16:21:59 +02:00
Tshepang Mbambo a08948f693
Merge pull request #2445 from smanilov/patch-23
Add title and toc to Async chapter
2025-06-02 16:18:44 +02:00
Stan Manilov f362726205
Add title and toc to Async chapter
This is standard for other chapters.
2025-06-02 17:16:29 +03:00
Stan Manilov 64ccd09863
Trivial: dedup word 2025-06-02 17:02:34 +03:00
Yukang 1a9be0c862
Rollup merge of #141894 - tshepang:rdg-push, r=jieyouxu
rustc-dev-guide subtree update

r? `@ghost`
2025-06-02 20:57:42 +08:00
Tshepang Mbambo 39300c4b70
distracting indirection 2025-06-02 12:34:19 +02:00
Tshepang Mbambo 9ad4ab9bb5 use a relative path, so that this also works offline 2025-06-02 12:30:08 +02:00
Tshepang Mbambo f3e892f57a
Merge pull request #2386 from Lysxia/fix-link
Fix link to GatherBorrows
2025-06-02 12:08:03 +02:00
Tshepang Mbambo 08e9bce01c
Merge pull request #2435 from smanilov/patch-19
Add opaque type attributes
2025-06-02 11:55:19 +02:00
Tshepang Mbambo 4bfb215935
Merge pull request #2437 from rust-lang/rustc-pull
Rustc pull update
2025-06-02 11:47:49 +02:00
Stan Manilov 294963c0c6
Trivial: fix typo (change `foo` to `bar`)
There is no `foo` symbol in the preceding example. I assume the method `bar` is meant.
2025-06-02 10:52:31 +03:00
The rustc-dev-guide Cronjob Bot a29099fb6c Merge from rustc 2025-06-02 04:08:41 +00:00
Stan Manilov f267718a78
Add opaque type attributes
This allows for the code to compile on `nightly`.
2025-06-01 10:36:28 +03:00
nora c067de3662
Merge pull request #2432 from rust-lang/tshepang-patch-1
suggest build/rust-analyzer instead of build-rust-analyzer
2025-05-31 22:53:01 +02:00
Tshepang Mbambo 8cf3cc09b9
replace a broken sentence 2025-05-31 22:30:00 +02:00
Tshepang Mbambo eabc382733
suggest build/rust-analyzer instead of build-rust-analyzer
This is better because
- `./x clean` also removes it, without needing extra text to explain it
- Does not need an extra .gitignore entry
2025-05-31 22:21:04 +02:00
onur-ozkan 257e73f3a3 improve comments and docs
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2025-05-30 21:04:14 +03:00
onur-ozkan 09eb3b3f78 update dev guidelines
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2025-05-30 21:04:08 +03:00
onur-ozkan 19a333ad0f split `mingw-check` into two
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2025-05-30 21:04:05 +03:00
许杰友 Jieyou Xu (Joe) 39644164b8
Merge pull request #2420 from rust-lang/aDotInTheVoid-patch-1
directives.md: Fix `//@ build_aux_docs` -> `//@ build-aux-docs`
2025-05-29 05:04:46 +08:00
Alona Enraght-Moony 655367d8b8 Fix some old `// <directive>` to `//@ <directive>` 2025-05-28 20:32:56 +01:00
Alona Enraght-Moony 812a949c11
directives.md: Fix `//@ build_aux_docs` -> `//@ build-aux-docs` 2025-05-28 20:18:56 +01:00
David Klank fa22636979
replace TraitRef link memory.md 2025-05-28 13:50:38 +03:00
Tshepang Mbambo 6da83f69ce
make link not inline 2025-05-27 21:21:18 +02:00
nora 568fbad863
Merge pull request #2417 from smanilov/patch-16
Make links in coinduction.md clickable
2025-05-27 18:53:29 +02:00
Stan Manilov e93a924d19 Make links in coinduction.md clickable
Although they are clickable in the github preview, they aren't in the actual rendered HTML on https://rustc-dev-guide.rust-lang.org/.

This commit fixes that.
2025-05-27 18:53:30 +03:00
Stan Manilov 01f8aee93b Link to description of opaque types 2025-05-27 18:50:31 +03:00
Tshepang Mbambo d90b7d7ac1
diagnostic translations work is on pause 2025-05-26 22:09:35 +02:00
Alona Enraght-Moony 482f61ad85
Remove rustdoc askama migration from getting started
This effort is blocked, so pointing new contributors here would be setting them up for failure.

https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/about.3A.20status.20of.20askama.20migration/with/497389045
2025-05-26 20:56:14 +01:00
Tshepang Mbambo e05b494faa
Merge pull request #2407 from smanilov/patch-14
Add time reference and tracking info for trait system refactor
2025-05-26 18:49:20 +02:00
Stan Manilov 03a857ec79 Add time reference and tracking info for trait system refactor 2025-05-26 15:43:07 +03:00