c6cd62cf77
Various improvements to `check_line_lengths.sh` ( #1667 )
2023-04-09 12:08:46 +09:00
b4b007be06
Don't require $GITHUB_TOKEN to build locally ( #1652 )
2023-03-27 00:28:07 +09:00
12f5d8d84f
have checkboxes only point to date-check lines in files ( #1603 )
...
They currently also point to filenames, which is redundant.
current
- [ ] thir.md
- [ ] line 7: 2022-04
- [ ] line 60: 2022-08
- [ ] traits/chalk.md
- [ ] line 4: 2022-05
proposed
- thir.md
- [ ] line 7: 2022-04
- [ ] line 60: 2022-08
- traits/chalk.md
- [ ] line 4: 2022-05
2023-02-16 20:38:25 -08:00
dc6fcaeae8
address review comment
...
https://github.com/rust-lang/rustc-dev-guide/pull/1428#discussion_r948143840
2022-08-25 19:56:58 -07:00
23ae7bb49f
make date-check more easy to use
...
One could not run it like the following, for the would be a panic:
cargo run --manifest-path ci/date-check/Cargo.toml .
Also, remove the need to specify argument, in which case, current_dir
is assumed.
2022-08-25 19:56:58 -07:00
81334fcda4
update date-check format on github issue ( #1416 )
...
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
2022-08-09 14:49:43 -07:00
7910832e02
date-check: be more strict
2022-08-02 17:22:34 -04:00
8194045511
make date-check more lightweight ( #1394 )
...
* make date-check lightweight
This avoids having to write the date twice when updating date-check.
Before "As of <-- 2022-07 --> July 2022"
After "As of July 2022"
* please clippy
* update date-check docs
* accept review suggestion
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#pullrequestreview-1042163557
* accept review suggestion
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#pullrequestreview-1042167261
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#issuecomment-1189105017
* this breaks markdown
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018268
This led to a more robust regex, though making the tool more picky.
It also found a wrong date format that was missed.
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018419
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018816
* accept review suggestion
This was reverted by mistake
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934019395
* use a more simple fn
* address review comment
https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018981
Much more clean
* nit
* accept review suggestion
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
* avoid a failed regex
Also, test new shape
* adjust to new regex (which uses named groups)
New regex was introduced by 456008cc35
2022-08-02 13:50:32 -07:00
123efb6fc2
Bump regex from 1.4.3 to 1.5.5 in /ci/date-check ( #1364 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-07 08:40:42 +09:00
4c4d9b5357
Update author field
2021-10-21 15:13:09 -05:00
9334db680b
Switch date-check to Rust 2021
...
No migrations were necessary.
2021-10-21 15:13:09 -05:00
52a33e718d
date-check: Recognize capitalized 'Date' as well
...
Now, if people use 'Date' instead of 'date', it won't be ignored.
2021-08-26 18:53:17 -05:00
34a1658c55
Link to Zulip search for finding the most recent check-in ( #1118 )
2021-04-29 17:40:25 -03:00
1f796c2929
Remove the possible unnecessary flag
2021-04-27 13:15:39 -04:00
ee94932928
Replace some Travis-related things completely
2021-04-27 13:15:39 -04:00
9930c8bd21
Check `BASE_SHA` only if it's a PR ( #1083 )
2021-03-11 15:50:34 +01:00
6dab96d7ea
Switch from Travis to GHA ( #1073 )
2021-03-10 11:51:56 -05:00
acd1390adb
Make check-in.sh output in way that suggest to add only the most relevant info
2021-02-04 10:10:08 -05:00
fe8a704c7e
Implement date-checker
...
This tool looks for HTML comments like `<!-- date: 2021-01 -->` in each
Markdown source file and compiles a list of dates that are older than
six months. It then opens an issue with that list, with checkboxes for
each file and date. Note that it will only open an issue if there was at
least one date older than six months; it does nothing if the list is
empty.
This tool is automatically run monthly in a GitHub Actions workflow.
I have tested the tool on a private repo and confirmed that it works.
2021-02-03 19:29:07 -05:00
2e19c8ecc0
Document how to stabilize a library feature ( #1036 )
...
* Move 'force-unstable-if-unmarked' to the bootstrapping chapter
* Document how to stabilize a library feature
Note that features can't be stabilized until they go through FCP and
that FCP happens on the tracking issue, not the PR.
* Fix wrong glob
By default `**` behaves the same as two `*` side by side, i.e. it only
globs file paths, not directories. `shopt -s globstar` needs to be set
for it to mean a directory. I didn't notice this before now because
`globstar` is set by default in interactive mode, but not otherwise.
2021-02-01 19:31:00 +01:00
a64e819af8
Improve contributor experience for the dev-guide itself ( #973 )
...
- Fix typos in the README
- Don't echo all instructions in the linkcheck.sh shellscript; this is
noisy and unhelpful when developing locally. Verbose output is still
enabled in CI.
- Link to the index page for compiler docs, not `rustc_middle`. Note
that the compiler docs are not a guide - that's us!
- Remove outdated instructions about avoiding 429s. These should no
longer be occurring locally now that we're using caching.
- Consolidate info about `mdbook` and `mdbook-linkcheck` near each other
2020-11-30 11:08:32 -03:00
5643607b1b
don't use cache while running PR builds
2020-11-23 18:42:24 -05:00
123c2a51aa
fix formatting
2020-10-22 09:08:04 -04:00
760c7edc03
Improve markdown formatting
2020-10-22 09:08:04 -04:00
3f9ed29687
Add a `check-in.sh` script to automate writing markdown links
...
Example usage:
```
$ ./check-in.sh
usage: ./check-in.sh <since> <number-of-prs-merged>
$ ./check-in.sh 2020-09-03
usage: ./check-in.sh <since> <number-of-prs-merged>
help: you can find the number of PRs merged at https://github.com/rust-lang/rustc-dev-guide/pulls?q=is%3Apr+is%3Aclosed+updated%3A%3E2020-09-03
$ ./check-in.sh 2020-09-03 72
Authors:
- **@1c3t3a**
- **@arora-aman**
... snip ...
Changes:
- Replace links to `buildbot2.r-l.o` with `bors.r-l.o` [#929 ](https://github.com/rust-lang/rustc-dev-guide/pull/929 )
- Add reference PRs for `r?` and `r+` comments [#928 ](https://github.com/rust-lang/rustc-dev-guide/pull/928 )
... snip ...
Changes in progress:
```
2020-10-22 09:08:04 -04:00
7f22d040f8
Better error message
...
Co-authored-by: Camelid <camelidcamel@gmail.com>
2020-10-08 17:11:36 -04:00
b10bdb58f4
Lol logic is hard
...
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
2020-10-08 17:11:36 -04:00
b2ba3d1c14
add assert
2020-10-08 17:11:36 -04:00
26c1c5ddce
More debuggable bash settings
...
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
2020-10-08 17:11:36 -04:00
7369dc03da
Add comment referring to travis docs
...
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
2020-10-08 17:11:36 -04:00
6ba01cf9eb
linkcheck only for changed files except in cron jobs
2020-10-08 17:11:36 -04:00
3f1414cb00
Recommend setting up `check_line_lengths` as a pre-commit script
...
I've run into lots of annoying failures from this.
- Make it runnable without arguments
- Add it in the README
2020-10-01 01:27:11 -04:00
0740d946f7
use cargo install
2020-01-30 21:47:13 -06:00
2d8434cec3
remove all the hacks, add some improvements
2019-11-05 11:58:33 -06:00
16e931f43e
Refactor (build CI script): minimizes the script, thanks to mark-i-m
2019-10-04 16:32:47 -05:00
bbaf50ac29
Fix (build CI script): fails early if linkcheck fails
2019-10-04 16:32:47 -05:00
a6e1c86d8b
Fix (build CI script):
...
* Removes timeout hack because it is not needed because we have upgraded mdbook_linkcheck
* Renamed build script because it is no longer ignoring timeouts
2019-10-04 16:32:47 -05:00
6b4949034b
Revert "Removes timeout script so CI does not have false positives"
...
This reverts commit c3ed0a1ef9
2019-10-04 16:32:47 -05:00
1c6dabdb6b
Removes timeout script so CI does not have false positives
2019-10-04 16:32:47 -05:00
6a0e3f667b
hack + drive-by-fix
2019-09-05 19:04:33 -05:00
589a4a2ea7
Updated the mdbook-linkcheck version
2019-09-05 17:03:24 -05:00
f2d1833f04
fix broken link ( #421 )
2019-08-13 11:56:02 -03:00
f2af67ab54
Remove leading new line
2019-08-06 17:18:07 -05:00
3046ae6638
hack around timeouts ( #416 )
2019-08-05 17:57:25 -03:00
d08d2dfd15
Update install.sh
2019-07-19 11:37:20 -05:00
d7997f6a87
Update mdbook
2019-07-19 11:37:20 -05:00
2f87467366
Update to mdbook-linkcheck 0.3.0
2019-06-24 09:52:03 -05:00
18feeb66aa
Update mdbook
2019-06-24 09:52:03 -05:00
0e93af6741
update mdbook
2019-03-01 17:16:50 -06:00
b692e893af
make the line-length script respect 100 char limit XD ( #240 )
...
🤣 🤣 🤣
2018-11-26 11:13:21 -06:00
jyn
Tshepang Mbambo
dependabot[bot]
Noah Lev
Joshua Nelson
JohnTitor
Santiago Pastorino
mark
Who? Me?!
Amanjeev Sethi
Michael Bryan