mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid "whitelist" 

Fixed according to 62cf767a4a
This commit is contained in:
Takayuki Nakata 2020-08-03 22:06:35 +09:00 committed by Who? Me?!
parent f28f707be4
commit ff9814cc3c
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/crates-io.md
View File

@ -14,10 +14,10 @@ reasons:
TODO: what is the vetting process? TODO: what is the vetting process?
## Whitelist ## Pemitted dependencies
The `tidy` tool has a [whitelist] of crates that are allowed. To add a The `tidy` tool has [crates that are allowed]. To add a
dependency that is not already in the compiler, you will need to add it to this dependency that is not already in the compiler, you will need to add it to these
whitelist. crates.
[whitelist]: https://github.com/rust-lang/rust/blob/659994627234ce7d95a1a52ad8756ce661059adf/src/tools/tidy/src/deps.rs#L56 [crates that are allowed]: https://github.com/rust-lang/rust/blob/19ecce332e56941ea0dd2a805270faa102acdb14/src/tools/tidy/src/deps.rs#L59

4
src/stability.md
View File

@ -76,11 +76,11 @@ Furthermore this attribute is needed to mark an intrinsic as callable from
Macros, compiler desugarings and `const fn`s expose their bodies to the call Macros, compiler desugarings and `const fn`s expose their bodies to the call
site. To work around not being able to use unstable things in the standard site. To work around not being able to use unstable things in the standard
library's macros, there's the `#[allow_internal_unstable(feature1, feature2)]` library's macros, there's the `#[allow_internal_unstable(feature1, feature2)]`
attribute that whitelists the given features for usage in stable macros or attribute that allows the given features for usage in stable macros or
`const fn`s. `const fn`s.
Note that `const fn`s are even more special in this regard. You can't just Note that `const fn`s are even more special in this regard. You can't just
whitelist any feature, the features need an implementation in allow any feature, the features need an implementation in
`qualify_min_const_fn.rs`. For example the `const_fn_union` feature gate allows `qualify_min_const_fn.rs`. For example the `const_fn_union` feature gate allows
accessing fields of unions inside stable `const fn`s. The rules for when it's accessing fields of unions inside stable `const fn`s. The rules for when it's
ok to use such a feature gate are that behavior matches the runtime behavior of ok to use such a feature gate are that behavior matches the runtime behavior of