mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com>
This commit is contained in:
Who? Me?! 2020-06-05 11:29:03 -05:00
parent 5e2d3c35ed
commit e492cf389b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/getting-started.md
View File

@ -132,7 +132,7 @@ the following settings:
- `incremental = true`: enables incremental compilation of the compiler itself. - `incremental = true`: enables incremental compilation of the compiler itself.
This is turned off by default because it's technically unsound. Sometimes This is turned off by default because it's technically unsound. Sometimes
this will cause weird crashes, but it can really speed things up. this will cause weird crashes, but it can really speed things up.
- `llvm-config`: enable building with system LLVM. [See this chapter][sysllvm] - `llvm-config`: enables building with system LLVM. [See this chapter][sysllvm]
for more info. This avoids building LLVM, which can take a while. for more info. This avoids building LLVM, which can take a while.
[sysllvm]: ./building/suggested.html#building-with-system-llvm [sysllvm]: ./building/suggested.html#building-with-system-llvm
@ -274,7 +274,7 @@ highlights, but there are a lot more details, which we will link to below.
### Code Review ### Code Review
When you open a PR on the `rust-lang/rust` repo, a bot called `@highfive` will When you open a PR on the `rust-lang/rust` repo, a bot called `@rust-highfive` will
automatically assign a reviewer to the PR. The reviewer is the person that will automatically assign a reviewer to the PR. The reviewer is the person that will
approve the PR to be tested and merged. If you want a specific reviewer (e.g. a approve the PR to be tested and merged. If you want a specific reviewer (e.g. a
team member you've been working with), you can specifically request them by team member you've been working with), you can specifically request them by
@ -334,7 +334,7 @@ The feature then needs to be implemented behind a feature gate, which prevents
it from being accidentally used. it from being accidentally used.
Finally, somebody may propose stabilizing the feature in an upcoming version of Finally, somebody may propose stabilizing the feature in an upcoming version of
Rust. This requires an FCP (see below) to get the approval of the relevant teams. Rust. This requires a Final Comment Period (see below) to get the approval of the relevant teams.
After that, the feature gate can be removed and the feature turned on for all users. After that, the feature gate can be removed and the feature turned on for all users.
@ -400,6 +400,6 @@ master.
- This guide: talks about how `rustc` works - This guide: talks about how `rustc` works
- [The t-compiler zulip][z] - [The t-compiler zulip][z]
- [The compiler's documentation (rustdocs)](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/) - [The compiler's documentation (rustdocs)](https://doc.rust-lang.org/nightly/nightly-rustc/)
TODO: am I missing any? TODO: am I missing any?