mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove a mention to Steve on r? example 

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
This commit is contained in:
Yuki Okushi 2022-07-18 10:02:06 +09:00 committed by Tshepang Mbambo
parent 168442374d
commit dca7b1b9c1
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/contributing.md
View File

@ -78,13 +78,12 @@ to review your request based on which files you changed.
If you want to request that a specific person reviews your pull request, you If you want to request that a specific person reviews your pull request, you
can add an `r?` to the pull request description or in a comment. For example, can add an `r?` to the pull request description or in a comment. For example,
[Steve][steveklabnik] usually reviews documentation changes. So if you were to if you want to ask a review to @awesome-reviewer, add
make a documentation change, add
r? @steveklabnik r? @awesome-reviewer
to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign
[@steveklabnik][steveklabnik] instead of a random person. This is entirely optional. them instead of a random person. This is entirely optional.
You can also assign a random reviewer from a specific team by writing `r? rust-lang/groupname`. You can also assign a random reviewer from a specific team by writing `r? rust-lang/groupname`.
So if you were making a diagnostics change, then you could get a reviewer from the diagnostics So if you were making a diagnostics change, then you could get a reviewer from the diagnostics
@ -135,7 +134,6 @@ speed the process up. Typically only small changes that are expected not to conf
with one another are marked as "always roll up". with one another are marked as "always roll up".
[rust-highfive]: https://github.com/rust-highfive [rust-highfive]: https://github.com/rust-highfive
[steveklabnik]: https://github.com/steveklabnik
[@bors]: https://github.com/bors [@bors]: https://github.com/bors
[merge-queue]: https://bors.rust-lang.org/queue/rust [merge-queue]: https://bors.rust-lang.org/queue/rust