mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove requests or suggestions about rebase and fixup contradictory to rust-highfive bot comment (#1111)

This commit is contained in:
Jesús Hernández 2021-06-24 18:50:50 +02:00 committed by GitHub
parent 3db8af26f9
commit c62c96ee6f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/contributing.md
View File

@ -145,8 +145,7 @@ CI will also run tidy and will fail if tidy fails.
Rust follows a _no merge-commit policy_, meaning, when you encounter merge Rust follows a _no merge-commit policy_, meaning, when you encounter merge
conflicts you are expected to always rebase instead of merging. E.g. always use conflicts you are expected to always rebase instead of merging. E.g. always use
rebase when bringing the latest changes from the master branch to your feature rebase when bringing the latest changes from the master branch to your feature
branch. Also, please make sure that fixup commits are squashed into other branch.
related commits with meaningful commit messages.
If you encounter merge conflicts or when a reviewer asks you to perform some If you encounter merge conflicts or when a reviewer asks you to perform some
changes, your PR will get marked as `S-waiting-on-author`. When you resolve changes, your PR will get marked as `S-waiting-on-author`. When you resolve