mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add 'waiting-for-review' incantation to main contrib page (#1124)

This commit is contained in:
Ralf Jung 2021-05-05 13:53:42 +02:00 committed by GitHub
parent 34a1658c55
commit c1e84b6c94
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/contributing.md
View File

@ -147,8 +147,12 @@ rebase when bringing the latest changes from the master branch to your feature
branch. Also, please make sure that fixup commits are squashed into other
related commits with meaningful commit messages.
If you encounter merge conflicts, your PR will get marked as `S-waiting-on-author`.
When you resolve them, you should use `@rustbot` to mark it as `S-waiting-on-review`.
If you encounter merge conflicts or when a reviewer asks you to perform some
changes, your PR will get marked as `S-waiting-on-author`. When you resolve
them, you should use `@rustbot` to mark it as `S-waiting-on-review`:
@rustbot label -S-waiting-on-author +S-waiting-on-review
See [this chapter][labeling] for more details.
GitHub allows [closing issues using keywords][closing-keywords]. This feature