ci: Remove incorrect use of `continue-on-error`
This will cause the CI build to be marked successful even if the build failed. Instead, use `if: '!cancelled()'` to always save the cache (except when the job is cancelled), even if the linkcheck failed. See https://stackoverflow.com/a/58859404 for more.
This commit is contained in:
parent
610e80b95c
commit
bb0051a006
|
|
@ -59,11 +59,10 @@ jobs:
|
||||||
|
|
||||||
- name: Check build
|
- name: Check build
|
||||||
run: ENABLE_LINKCHECK=1 mdbook build
|
run: ENABLE_LINKCHECK=1 mdbook build
|
||||||
continue-on-error: true
|
|
||||||
|
|
||||||
- name: Save cached Linkcheck
|
- name: Save cached Linkcheck
|
||||||
id: cache-linkcheck-save
|
id: cache-linkcheck-save
|
||||||
if: github.event_name == 'schedule'
|
if: ${{ !cancelled() && github.event_name == 'schedule' }}
|
||||||
uses: actions/cache/save@v4
|
uses: actions/cache/save@v4
|
||||||
with:
|
with:
|
||||||
path: book/linkcheck/cache.json
|
path: book/linkcheck/cache.json
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue