mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

toolchain version does not need to be specified 

- Rust backcompat removes the need to specify the version here
- Using these commands can result in a needless toolchain getting
  downloaded, like in the case where user only has Nightly installed
This commit is contained in:
Tshepang Mbambo 2025-04-19 13:34:13 +02:00
parent 1fdfd58142
commit ac84606523
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/rustc-pull.yml vendored
View File

@ -28,7 +28,7 @@ jobs:
# Cache the josh directory with checked out rustc # Cache the josh directory with checked out rustc
cache-directories: "/home/runner/.cache/rustc-dev-guide-josh" cache-directories: "/home/runner/.cache/rustc-dev-guide-josh"
- name: Install josh - name: Install josh
run: RUSTFLAGS="--cap-lints warn" cargo +stable install josh-proxy --git https://github.com/josh-project/josh --tag r24.10.04 run: RUSTFLAGS="--cap-lints warn" cargo install josh-proxy --git https://github.com/josh-project/josh --tag r24.10.04
- name: Setup bot git name and email - name: Setup bot git name and email
run: | run: |
git config --global user.name 'The rustc-dev-guide Cronjob Bot' git config --global user.name 'The rustc-dev-guide Cronjob Bot'

4
README.md
View File

@ -77,7 +77,7 @@ This repository is linked to `rust-lang/rust` as a [josh](https://josh-project.g
You'll need to install `josh-proxy` locally via You'll need to install `josh-proxy` locally via
``` ```
cargo +stable install josh-proxy --git https://github.com/josh-project/josh --tag r24.10.04 cargo install josh-proxy --git https://github.com/josh-project/josh --tag r24.10.04
``` ```
Older versions of `josh-proxy` may not round trip commits losslessly so it is important to install this exact version. Older versions of `josh-proxy` may not round trip commits losslessly so it is important to install this exact version.
@ -106,5 +106,5 @@ You may observe "Nothing to pull" even if you *know* rustc-pull has something to
To minimize the likelihood of this happening, you may wish to keep a separate *minimal* git config that *only* has `[user]` entries from global git config, then repoint system git to use the minimal git config instead. E.g. To minimize the likelihood of this happening, you may wish to keep a separate *minimal* git config that *only* has `[user]` entries from global git config, then repoint system git to use the minimal git config instead. E.g.
``` ```
GIT_CONFIG_GLOBAL=/path/to/minimal/gitconfig GIT_CONFIG_SYSTEM='' cargo +stable run --manifest-path josh-sync/Cargo.toml -- rustc-pull GIT_CONFIG_GLOBAL=/path/to/minimal/gitconfig GIT_CONFIG_SYSTEM='' cargo run --manifest-path josh-sync/Cargo.toml -- rustc-pull
``` ```