mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable linkcheck in PRs until bugs are fixed 

See https://github.com/Michael-F-Bryan/mdbook-linkcheck/issues/77
and https://github.com/Michael-F-Bryan/mdbook-linkcheck/issues/86.

These bugs are causing linkcheck to erroneously fail because we run it
using `-f`, to avoid too many requests. For now, disable linkcheck in PR
CI, though leave it enabled in the cron job, where the bug should not
occur.
This commit is contained in:
Noah Lev 2024-08-06 13:17:04 -07:00
parent bacd3c57b1
commit 7d522989ff
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ci/linkcheck.sh
View File

@ -14,6 +14,9 @@ if [ "$GITHUB_EVENT_NAME" = "schedule" ] ; then # running in scheduled job
echo "Doing full link check."
elif [ "$GITHUB_EVENT_NAME" = "pull_request" ] ; then # running in PR CI build
echo "*** WARNING: linkcheck temporarily disabled due to bugs ***"
exit 0
if [ -z "$BASE_SHA" ]; then
echo "error: unexpected state: BASE_SHA must be non-empty in CI"
exit 1
@ -25,6 +28,9 @@ elif [ "$GITHUB_EVENT_NAME" = "pull_request" ] ; then # running in PR CI build
echo "Checking files changed since $BASE_SHA: $CHANGED_FILES"
else # running locally
echo "*** WARNING: linkcheck temporarily disabled due to bugs ***"
exit 0
COMMIT_RANGE=master...
CHANGED_FILES=$(git diff --name-only $COMMIT_RANGE | sed 's#^src/##' | tr '\n' ' ')
FLAGS="-f $CHANGED_FILES"