mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add a paragraph about reviewers and review latency in Getting Started chapter

This commit is contained in:
LeSeulArtichaut 2020-10-03 20:30:30 +02:00 committed by Who? Me?!
parent 6a5b29b31e
commit 3d6d0e04ed
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/getting-started.md
View File

@ -385,10 +385,21 @@ team member you've been working with), you can specifically request them by
writing `r? @user` (e.g. `r? @eddyb`) in either the original post or a followup writing `r? @user` (e.g. `r? @eddyb`) in either the original post or a followup
comment. comment.
Please note that the reviewers are humans, who for the most part work on `rustc`
in their free time. This means that they can take some time to respond and review
your PR. It also means that reviewers can miss some PRs that are assigned to them.
To try to move PRs forward, the Triage WG regularely goes through all PRs that
are waiting for review and haven't been discussed for at least a week. If you
don't get a review within around 10 days, feel free to ask the Triage WG on
Zulip ([#t-release/triage]). They have knowledge of when to ping, who might be
on vacation, etc...
The reviewer may request some changes using the GitHub code review interface. The reviewer may request some changes using the GitHub code review interface.
They may also request special procedures (such as a [crater] run; [see They may also request special procedures (such as a [crater] run; [see
below][break]) for some PRs. below][break]) for some PRs.
[#t-release/triage]: https://rust-lang.zulipchat.com/#narrow/stream/242269-t-release.2Ftriage
[break]: #breaking-changes [break]: #breaking-changes
When the PR is ready to be merged, the reviewer will issue a command to When the PR is ready to be merged, the reviewer will issue a command to