mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix various minor points

This commit is contained in:
Niko Matsakis 2018-08-31 14:46:03 -04:00 committed by Who? Me?!
parent d133eefac1
commit 21222aaf4c
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/SUMMARY.md
View File

@ -1,9 +1,9 @@
# Summary # Summary
- [About this guide](./about-this-guide.md) - [About this guide](./about-this-guide.md)
- [About the compiler team](./compiler-team.md)
- [How to build the compiler and run what you built](./how-to-build-and-run.md) - [How to build the compiler and run what you built](./how-to-build-and-run.md)
- [Coding conventions](./conventions.md) - [Coding conventions](./conventions.md)
- [About the compiler team](./compiler-team.md)
- [The compiler testing framework](./tests/intro.md) - [The compiler testing framework](./tests/intro.md)
- [Running tests](./tests/running.md) - [Running tests](./tests/running.md)
- [Adding new tests](./tests/adding.md) - [Adding new tests](./tests/adding.md)

10
src/compiler-team.md
View File

@ -32,9 +32,9 @@ The meeting currently takes place on Thursdays at 10am Boston time
(UTC-4 typically, but daylight savings time sometimes makes things (UTC-4 typically, but daylight savings time sometimes makes things
complicated). complicated).
The meeting is held over a "chat medium" -- it used to be IRC, but we The meeting is held over a "chat medium" — it used to be IRC, but we
are currently in the process of evaluating other alternatives. Check are currently in the process of evaluating other alternatives. Check
[the etherpad] to find the current home (and see the [etherpad] to find the current home (and see
[this internals thread][thread] for some ongoing discussion). [this internals thread][thread] for some ongoing discussion).
[etherpad]: https://public.etherpad-mozilla.org/p/rust-compiler-meeting [etherpad]: https://public.etherpad-mozilla.org/p/rust-compiler-meeting
@ -85,7 +85,7 @@ rotation. high-five is the bot that assigns incoming PRs to
reviewers. If you are added, you will be randomly selected to review reviewers. If you are added, you will be randomly selected to review
PRs. If you find you are assigned a PR that you don't feel comfortable PRs. If you find you are assigned a PR that you don't feel comfortable
reviewing, you can also leave a comment like `r? @so-and-so` to assign reviewing, you can also leave a comment like `r? @so-and-so` to assign
to someone else -- if you don't know who to request, just write `r? to someone else — if you don't know who to request, just write `r?
@nikomatsakis for reassignment` and @nikomatsakis will pick someone @nikomatsakis for reassignment` and @nikomatsakis will pick someone
for you. for you.
@ -96,11 +96,11 @@ review burden for all of us! However, if you don't have time to give
people timely feedback on their PRs, it may be better that you don't people timely feedback on their PRs, it may be better that you don't
get on the list. get on the list.
### Team membership ### Full team membership
Full team membership is typically extended once someone made many Full team membership is typically extended once someone made many
contributions to the Rust compiler over time, ideally (but not contributions to the Rust compiler over time, ideally (but not
necessarily) to multiple areas. Sometimes this might be implementing a necessarily) to multiple areas. Sometimes this might be implementing a
new feature, but it is also important -- perhaps more important! -- to new feature, but it is also important — perhaps more important! — to
have time and willingness to help out with general upkeep such as have time and willingness to help out with general upkeep such as
bugfixes, tracking regressions, and other less glamorous work. bugfixes, tracking regressions, and other less glamorous work.