mirror
/
rustc-dev-guide
mirror of https://github.com/rust-lang/rustc-dev-guide.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix long lines

This commit is contained in:
Wesley Wiser 2023-08-22 10:30:26 -04:00 committed by David Wood
parent d6c20e4146
commit 17f7bb3f76
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/licenses.md
View File

@ -6,26 +6,33 @@ Detailed licensing information is available in the [COPYRIGHT document](https://
## Guidelines for reviewers ## Guidelines for reviewers
In general, reviewers need to be looking not only for the code quality of contributions but also that they are properly licensed. In general, reviewers need to be looking not only for the code quality of contributions but also
We have some tips below for things to look out for when reviewing, but if you ever feel uncertain as to whether some code might be properly licensed, err on the safe side — reach out to the Council or Compiler Team Leads for feedback! that they are properly licensed.
We have some tips below for things to look out for when reviewing, but if you ever feel uncertain
as to whether some code might be properly licensed, err on the safe side — reach out to the Council
or Compiler Team Leads for feedback!
Things to watch out for: Things to watch out for:
- The PR author states that they copied, ported, or adapted the code from some other source. - The PR author states that they copied, ported, or adapted the code from some other source.
- There is a comment in the code pointing to a webpage or describing where the algorithm was taken from. - There is a comment in the code pointing to a webpage or describing where the algorithm was taken
from.
- The algorithm or code pattern seems like it was likely copied from somewhere else. - The algorithm or code pattern seems like it was likely copied from somewhere else.
- When adding new dependencies, double check the dependency's license. - When adding new dependencies, double check the dependency's license.
In all of these cases, we will want to check that source to make sure it it is licensed in a way that is compatible with Rust’s license. In all of these cases, we will want to check that source to make sure it it is licensed in a way
that is compatible with Rust’s license.
Examples Examples
- Porting C code from a GPL project, like GNU binutils, is not allowed. That would require rust itself to be licensed under the GPL. - Porting C code from a GPL project, like GNU binutils, is not allowed. That would require Rust
itself to be licensed under the GPL.
- Copying code from an algorithms text book may be allowed, but some algorithms are patented. - Copying code from an algorithms text book may be allowed, but some algorithms are patented.
## Porting ## Porting
Contributions to rustc, especially around platform and compiler intrinsics, often include porting over work from other projects, mainly LLVM and GCC. Contributions to rustc, especially around platform and compiler intrinsics, often include porting
over work from other projects, mainly LLVM and GCC.
Some general rules apply: Some general rules apply:
@ -33,6 +40,8 @@ Some general rules apply:
- This applies to direct copy & paste - This applies to direct copy & paste
- This also applies to code you looked at and ported - This also applies to code you looked at and ported
In general, taking inspiration from other codebases is fine, but please exercise caution when porting code. In general, taking inspiration from other codebases is fine, but please exercise caution when
porting code.
Ports of full libraries (e.g. C libraries shipped with LLVM) must keep the license of the original library. Ports of full libraries (e.g. C libraries shipped with LLVM) must keep the license of the original
library.