mirror
/
r2r
mirror of https://github.com/sequenceplanner/r2r.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Copy topic name before deleting subscription. 

This fixes undefined behaviour, as the
rcl_subscription_get_topic_name documentation
states that the topic is no longer valid when
the subscription dies
This commit is contained in:
Tobias Stark 2024-10-08 12:51:47 +00:00 committed by Martin Dahl
parent 89cec03d07
commit a35d541378
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
r2r/src/subscribers.rs
View File

@ -105,7 +105,7 @@ where
drop(Box::from_raw(handle_ptr));
} else {
let topic_str = rcl_subscription_get_topic_name(handle_ptr);
let topic = CStr::from_ptr(topic_str);
let topic = CStr::from_ptr(topic_str).to_str().expect("to_str() call failed").to_owned();
drop(Box::from_raw(handle_ptr));
let err_str = rcutils_get_error_string();
@ -118,7 +118,7 @@ where
panic!(
"rcl_return_loaned_message_from_subscription() \
failed for subscription on topic {}: {}",
topic.to_str().expect("to_str() call failed"),
topic,
error_msg.to_str().expect("to_str() call failed")
);
}