go/src
Matthew Dempsky fd43831f44 [dev.regabi] cmd/compile: reimplement capture analysis
Currently we rely on the type-checker to do some basic data-flow
analysis to help decide whether function literals should capture
variables by value or reference. However, this analysis isn't done by
go/types, and escape analysis already has a better framework for doing
this more precisely.

This CL extends escape analysis to recalculate the same "byval" as
CaptureVars and check that it matches. A future CL will remove
CaptureVars in favor of escape analysis's calculation.

Notably, escape analysis happens after deadcode removes obviously
unreachable code, so it sees the AST without any unreachable
assignments. (Also without unreachable addrtakens, but
ComputeAddrtaken already happens after deadcode too.) There are two
test cases where a variable is only reassigned on certain CPUs. This
CL changes them to reassign the variables unconditionally (as no-op
reassignments that avoid triggering cmd/vet's self-assignment check),
at least until we remove CaptureVars.

Passes toolstash -cmp.

Change-Id: I7162619739fedaf861b478fb8d506f96a6ac21f3
Reviewed-on: https://go-review.googlesource.com/c/go/+/281535
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
2021-01-05 21:11:38 +00:00
..
archive all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
bufio
builtin
bytes
cmd [dev.regabi] cmd/compile: reimplement capture analysis 2021-01-05 21:11:38 +00:00
compress all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
container
context
crypto [dev.regabi] all: merge master into dev.regabi 2020-12-21 11:19:04 -08:00
database/sql database/sql: fix typo in comment 2020-12-10 18:23:15 +00:00
debug debug/dwarf: don't try to parse addr/rnglists header 2020-12-14 18:06:06 +00:00
embed [dev.regabi] cmd/compile: separate noder more cleanly 2020-12-21 19:23:30 +00:00
encoding
errors
expvar
flag
fmt
go [dev.regabi] all: merge master into dev.regabi 2020-12-21 11:19:04 -08:00
hash all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
html html/template: avoid race when escaping updates template 2020-12-17 03:20:55 +00:00
image all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
index/suffixarray all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
internal all: update to use os.ReadDir where appropriate 2020-12-09 19:12:27 +00:00
io io/fs: fix package reference in FS godoc 2020-12-14 22:04:37 +00:00
log all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
math math/big: add test for recursive division panic 2020-12-14 20:56:03 +00:00
mime all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
net net/mail: don't use MDT in test 2020-12-25 23:54:24 +00:00
os os/signal: fix a deadlock with syscall.AllThreadsSyscall() use 2020-12-23 05:27:04 +00:00
path all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
plugin
reflect reflect: document multiple keys in struct tags 2020-12-07 22:16:21 +00:00
regexp
runtime [dev.regabi] all: merge master (1d78139) into dev.regabi 2020-12-28 00:12:16 -08:00
sort all: update to use os.ReadFile, os.WriteFile, os.CreateTemp, os.MkdirTemp 2020-12-09 19:12:23 +00:00
strconv Merge branch 'master' into dev.regabi 2020-12-14 11:42:42 -05:00
strings
sync
syscall [dev.regabi] all: merge master (1d78139) into dev.regabi 2020-12-28 00:12:16 -08:00
testdata
testing all: update to use os.ReadDir where appropriate 2020-12-09 19:12:27 +00:00
text text/template: error on range over send channel 2020-12-15 13:59:00 +00:00
time lib/time, time/tzdata: update tzdata to 2020e 2020-12-23 17:29:16 +00:00
unicode
unsafe
vendor std: update golang.org/x/net to 20201209123823-ac852fbbde11 2020-12-10 18:27:38 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod std: update golang.org/x/net to 20201209123823-ac852fbbde11 2020-12-10 18:27:38 +00:00
go.sum std: update golang.org/x/net to 20201209123823-ac852fbbde11 2020-12-10 18:27:38 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.