Suzy Mueller fc82fb2afd internal/lsp: return error when renaming within an import spec ... Since renaming an identifier within an import spec is not yet supported, return an error when this is encountered. These idents from the import spec have a nil declaration object. Import paths that contain '.' or '/' are caught by the valid identifier check avoiding the crash, but import paths such as "fmt" are not as fmt is a valid identifier. This change checks if i.decl.obj is nil and returns an error if it is to avoid the crash. Fixes golang/go#33768 Change-Id: I4e757b42bedffd648fc821590e4a383826200dc3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/191163 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>		2019-08-22 00:03:11 +00:00
..
apidiff	apidiff: represent a Report as a list of Changes	2019-04-22 23:39:26 +00:00
fastwalk	internal/fastwalk: avoid slice bounds out of range for long file names	2018-11-12 23:16:31 +00:00
gopathwalk	internal/gopathwalk: fix typo ("nonexistant" → "nonexistent")	2019-08-02 00:38:18 +00:00
imports	internal/imports: save information about the module cache	2019-08-20 18:54:49 +00:00
jsonrpc2	internal/lsp: use a background context for the background worker	2019-07-18 19:01:55 +00:00
lsp	internal/lsp: return error when renaming within an import spec	2019-08-22 00:03:11 +00:00
memoize	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00
module	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
semver	go/packages: add name= query	2018-10-16 20:20:09 +00:00
span	internal/span: handle character values beyond end of line in FromUTF16Column	2019-07-06 07:08:13 +00:00
telemetry	internal/telemetry: add the ability to flush telemetry data	2019-08-21 16:29:56 +00:00
tool	internal/tool: add a small package to unify the flag handling across all our tools	2018-12-17 23:08:00 +00:00
txtar	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00