Daniel Martí 15b4c71a91 text/template: error on method calls on nil interfaces ... Trying to call a method on a nil interface is a panic in Go. For example: var stringer fmt.Stringer println(stringer.String()) // nil pointer dereference In https://golang.org/cl/143097 we started recovering panics encountered during function and method calls. However, we didn't handle this case, as text/template panics before evalCall is ever run. In particular, reflect's MethodByName will panic if the receiver is of interface kind and nil: panic: reflect: Method on nil interface value Simply add a check for that edge case, and have Template.Execute return a helpful error. Note that Execute shouldn't just error if the interface contains a typed nil, since we're able to find a method to call in that case. Finally, add regression tests for both the nil and typed nil interface cases. Fixes #30143. Change-Id: Iffb21b40e14ba5fea0fcdd179cd80d1f23cabbab Reviewed-on: https://go-review.googlesource.com/c/161761 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>		2019-02-26 18:05:09 +00:00
..
scanner	text/scanner: don't liberally consume (invalid) floats or underbars	2019-02-20 20:23:28 +00:00
tabwriter	text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged again	2018-06-04 17:32:17 +00:00
template	text/template: error on method calls on nil interfaces	2019-02-26 18:05:09 +00:00