go/internal/lsp/testdata/signature
Karthik Nayak 4fe0d6c80e internal/lsp: skip signature help within a string literal
Currently the `SignatureHelp` function provides signature help even when the
requested range lies within a string literal. Let's suppress this behavior and
return an error when someone requests signature help from within a string
literal.

Fixes golang/go#43397

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

Change-Id: Ib03e87258622f4294bf9385bf5f0a8effe0050ee
GitHub-Last-Rev: 0c9549ae68b0263a3cac274da133e9ab4b4c7bf5
GitHub-Pull-Request: golang/tools#332
Reviewed-on: https://go-review.googlesource.com/c/tools/+/337170
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Robert Findley <rfindley@google.com>
Trust: Peter Weinberger <pjw@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-07-26 16:44:13 +00:00
..
signature.go internal/lsp: skip signature help within a string literal 2021-07-26 16:44:13 +00:00
signature.go.golden internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00
signature2.go.golden internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00
signature2.go.in internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00
signature3.go.golden internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00
signature3.go.in internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00
signature_test.go internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00
signature_test.go.golden internal/lsp: remove multi-module support in tests 2020-09-22 16:28:30 +00:00