go/internal/imports
Heschi Kreinick b894a3290f all: use explicit -mod, -modfile fields for gocommand.Invocation
Build flags, -mod, and -modfile are all accepted by disjoint go command
verbs. Mixing them together had the effect of forcing gocommand users to
figure out which went where themselves, which was annoying and
error-prone. Add ModFlag and ModFile fields to Invocation and update all
uses to use them.

go/packages has a BuildFlags field that's bad for the same reason. Add
private modFlag and modFile fields that forward to the corresponding
Invocation fields.

imports.ProcessEnv gets the same treatment.

Fixes golang/go#41826.

Change-Id: If74d19146e9e62930d7c34f40859c27c25566c4e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/263213
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-10-19 17:57:15 +00:00
..
testdata/mod imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
fix.go all: use explicit -mod, -modfile fields for gocommand.Invocation 2020-10-19 17:57:15 +00:00
fix_test.go internal/imports: bump relevance for modules with higher major versions 2020-10-13 19:42:24 +00:00
imports.go internal/imports: require valid options, move LocalPrefix up 2020-07-07 20:02:13 +00:00
imports_test.go internal/imports: require valid options, move LocalPrefix up 2020-07-07 20:02:13 +00:00
mkindex.go imports: rename to internal/imports 2019-05-20 21:49:35 +00:00
mkstdlib.go internal/imports: update stdlib index for 1.15 2020-08-04 21:03:08 +00:00
mod.go all: use explicit -mod, -modfile fields for gocommand.Invocation 2020-10-19 17:57:15 +00:00
mod_cache.go internal/imports: stop leaking listeners 2020-02-04 05:47:48 +00:00
mod_cache_test.go internal/imports: clean up dead code 2019-12-30 21:21:44 +00:00
mod_test.go internal/imports: bump relevance for modules with higher major versions 2020-10-13 19:42:24 +00:00
sortimports.go internal/imports: require valid options, move LocalPrefix up 2020-07-07 20:02:13 +00:00
zstdlib.go internal/imports: update stdlib index for 1.15 2020-08-04 21:03:08 +00:00