f0b3626904
If we've already imported a named type, then there's no need to process its associated methods except to validate that the signature matches the existing known method. However, the current import code still creates a new function node for each method, saves its inline body (if any), and adds the node to the global importlist. Because of this, the duplicate methods are never garbage collected. This CL changes the compiler to avoid amassing uncollectable garbage or performing any unnecessary processing. This is particularly noticeable for protobuf-heavy code. For the motivating Go package, this CL reduced compile max-RSS from ~12GB to ~3GB and compile time from ~65s to ~50s. Passes toolstash -cmp for std, cmd, and k8s.io/kubernetes/cmd/.... Change-Id: Ib53ba9f2ad3212995671cf6ba220ee8a56d8d009 Reviewed-on: https://go-review.googlesource.com/51331 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| favicon.ico | ||
| robots.txt | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.