go/internal/lsp
Rebecca Stambler f04f2c82d0 internal/lsp/cache: refactor initialization for builtins
This change combines the two packages.Load calls that happen on view
creation. Builtins can be loaded along with the rest of the workspace.

To avoid race conditions, create a builtinPackageHandle type for
builtins and use it to create the data.

Updates golang/go#36531

Change-Id: I7aa342c463a0b7718e1ad5fee507622310d8443b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/214877
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-01-15 21:04:26 +00:00
..
browser
cache internal/lsp/cache: refactor initialization for builtins 2020-01-15 21:04:26 +00:00
cmd internal/lsp: add and use nonstandard gopls/diagnoseFiles 2020-01-15 19:23:06 +00:00
debug internal/lsp: add server instance to debug info 2020-01-15 14:58:21 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: make golint happy 2019-12-23 18:17:04 +00:00
mod internal/lsp/cache: refactor initialization for builtins 2020-01-15 21:04:26 +00:00
protocol internal/lsp/protocol: support nonstandard requests 2020-01-14 21:52:24 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp,internal/telemetry: correct stale docstrings 2020-01-15 14:25:42 +00:00
telemetry internal/lsp: load metadata for a single package ID, when needed 2019-12-30 21:09:35 +00:00
testdata internal/imports: load test exports of package under test 2020-01-14 23:54:10 +00:00
tests internal/lsp: show dependency quick fixes for go.mod diagnostics 2020-01-15 16:51:05 +00:00
code_action.go internal/lsp: show dependency quick fixes for go.mod diagnostics 2020-01-15 16:51:05 +00:00
command.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
completion.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion_test.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
definition.go internal/lsp: finish renaming CheckPackageHandle to PackageHandle 2020-01-14 23:56:10 +00:00
diagnostics.go internal/lsp: make sure diagnostics with analyses are not overwritten 2020-01-14 22:43:10 +00:00
folding_range.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
format.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
general.go internal/lsp: prevent initial workspace load from being canceled 2020-01-10 21:08:40 +00:00
highlight.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
hover.go internal/lsp: finish renaming CheckPackageHandle to PackageHandle 2020-01-14 23:56:10 +00:00
implementation.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
link.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
lsp_test.go internal/lsp: show dependency quick fixes for go.mod diagnostics 2020-01-15 16:51:05 +00:00
references.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
rename.go internal/lsp: finish renaming CheckPackageHandle to PackageHandle 2020-01-14 23:56:10 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: add and use nonstandard gopls/diagnoseFiles 2020-01-15 19:23:06 +00:00
signature_help.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
symbols.go internal/lsp: remove view.FindPosInPackage and view.FindMapperInPackage 2020-01-13 18:51:11 +00:00
text_synchronization.go internal/lsp: fix support for watching changed files 2020-01-13 19:19:55 +00:00
workspace.go internal/lsp: prevent initial workspace load from being canceled 2020-01-10 21:08:40 +00:00