go/src
Bryan C. Mills ef3ef8fcdf net/http: use cancellation instead of a timeout in TestTransportProxyHTTPSConnectTimeout
The use of a timeout in this test caused it to be flaky: if the
timeout occurred before the connection was attempted, then the Accept
call on the Listener could hang indefinitely, and its goroutine would
not exit until that Listener was closed. That caused the test to fail.

A longer timeout would make the test less flaky, but it would become
even slower and would still be sensitive to timing.

Instead, replace the timeout with an explicit Context cancellation
after the CONNECT request has been read. That not only ensures that
the cancellation occurs at the appropriate point, but also makes the
test much faster: a test run with -count=1000 now executes in less
than 2s on my machine, whereas before it took upwards of 50s.

Fixes #36082
Updates #28012

Change-Id: I00c20d87365fd3d257774422f39d2acc8791febd
Reviewed-on: https://go-review.googlesource.com/c/go/+/210857
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-11 15:43:50 +00:00
..
archive all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
bufio bufio: return the underlying error in ReadFrom if not nil 2019-10-31 17:21:56 +00:00
builtin
bytes hash/maphash: move bytes/hash to hash/maphash 2019-11-02 18:30:37 +00:00
cmd cmd/compile/internal/logopt: gofmt 2019-12-10 21:31:00 +00:00
compress all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
container
context context: mark testDeadline as a testing helper method 2019-10-29 14:22:15 +00:00
crypto all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
database/sql
debug all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
encoding all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
errors
expvar
flag flag: clarify that a flag cannot be re-defined 2019-11-11 20:07:54 +00:00
fmt fmt: fix handling of %% verb in Scanf 2019-10-25 04:15:59 +00:00
go go/ast: fix a few incorrect "an" articles 2019-12-09 02:02:17 +00:00
hash hash/maphash: mark call into runtime hash function as not escaping 2019-11-16 20:31:45 +00:00
html text/template: harden JSEscape to also escape ampersand and equal 2019-11-21 22:20:17 +00:00
image
index/suffixarray
internal all: fix most of the remaining windows -d=checkptr violations 2019-12-06 05:10:34 +00:00
io all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
log
math math/rand: update comment to avoid use of ^ for exponentiation 2019-12-04 21:14:24 +00:00
mime
net net/http: use cancellation instead of a timeout in TestTransportProxyHTTPSConnectTimeout 2019-12-11 15:43:50 +00:00
os os: skip a new failing test on Windows 2019-12-06 18:04:42 +00:00
path path: minor changes to improve documentation for Join 2019-11-20 20:51:13 +00:00
plugin
reflect all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
regexp
runtime runtime: syscall_forkx on Solaris can return error on success 2019-12-11 01:10:28 +00:00
sort
strconv strconv: reformat and tidy comments in example 2019-11-11 19:56:33 +00:00
strings strings: fix nonexistent path in comment 2019-12-06 20:12:47 +00:00
sync sync: deflake TestWaitGroupMisuse3 2019-12-06 05:12:15 +00:00
syscall syscall: use SOCK_CLOEXEC when creating sockets 2019-12-11 00:01:17 +00:00
testdata
testing testing: use conventional comments for exported internal funcs & structs 2019-12-10 21:11:20 +00:00
text text/template: harden JSEscape to also escape ampersand and equal 2019-11-21 22:20:17 +00:00
time time: fix comment in test 2019-12-02 16:11:24 +00:00
unicode unicode: upgrade to Unicode 12 2019-11-05 14:34:56 +00:00
unsafe
vendor src/go.mod: sync golang.org/x/net with h2_bundle.go 2019-12-05 16:20:26 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod src/go.mod: sync golang.org/x/net with h2_bundle.go 2019-12-05 16:20:26 +00:00
go.sum src/go.mod: sync golang.org/x/net with h2_bundle.go 2019-12-05 16:20:26 +00:00
iostest.bash
make.bash make.bash: show bootstrap version 2019-11-01 20:45:04 +00:00
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.