Iskander Sharipov ec14b29651 internal/lsp/source: fix all types in resolveInvalid ... This CL teaches lsp to report `**T` instead of `**invalid type`, `func (badParam) badResult` instead of `func (invalid type) invalid type`, etc. To do that, we need to detect "invalid type" inside any part of a type. I've added typeIsValid() function for that. To simplify type formating code in resolveInvalid(), formatNode function is added that can also format *ast.StarExpr (of any depth). Since we already used AST printer in the same file, I added formatNode function that is now used in both places. While at it, replaced bytes.Buffer to strings.Builder there. Change-Id: I3bb84c58c417b175cceefb410e238c48425f7cee Reviewed-on: https://go-review.googlesource.com/c/tools/+/210357 Run-TryBot: Iskander Sharipov <quasilyte@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-12-11 23:00:51 +00:00
..
apidiff	all: fix more typos	2019-09-11 15:13:14 +00:00
fastwalk	internal/fastwalk: avoid slice bounds out of range for long file names	2018-11-12 23:16:31 +00:00
gopathwalk	internal/imports: cache things outside the mod cache	2019-10-21 20:45:41 +00:00
imports	internal/lsp/source: optimize computeFixEdits	2019-12-06 20:21:26 +00:00
jsonrpc2	internal/lsp: cancel early	2019-10-22 07:49:31 +00:00
lsp	internal/lsp/source: fix all types in resolveInvalid	2019-12-11 23:00:51 +00:00
memoize	internal/memoize: fix race on read of handle.function	2019-12-05 18:38:34 +00:00
module	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
semver	go/packages: add name= query	2018-10-16 20:20:09 +00:00
span	internal/span: support line directives	2019-11-25 19:20:43 +00:00
telemetry	internal/telemetry: lift the tests up to the request level	2019-11-27 15:41:43 +00:00
testenv	internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT	2019-11-11 19:22:22 +00:00
tool	tools/internal/tool: refactor tool.Main() for testabilty	2019-09-19 22:27:22 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00