Alan Donovan 32e1cb7aed gopls/internal/lsp: clarify control around diagnostics ... This CL includes some clarifications while trying to understand the performance of the initial workspace load and analysis. No significant behavior changes. Server.diagnose: - Factor the four copies of the logic for dealing with diagnostics and errors. - Make the ActivePackages blocking step explicit. Previously mod.Diagnostics would do this implicitly, making it look more expensive than it is. Server.addFolders: - eliminate TODO. The logic is not in fact fishy. - use informative names and comments for WaitGroups. - use a channel in place of a non-counting WaitGroup. Also, give pkg a String method. Change-Id: Ia3eff4e784fc04796b636a4635abdfe8ca4e7b5a Reviewed-on: https://go-review.googlesource.com/c/tools/+/445897 Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Alan Donovan <adonovan@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>		2022-11-01 21:03:16 +00:00
..
analysis.go	gopls/internal/lsp/cache: add PkgPath->PackageID index to Metadata	2022-10-20 21:54:57 +00:00
cache.go	gopls/internal/span: move internal/span into gopls	2022-10-07 14:50:44 +00:00
check.go	gopls/internal/lsp/cache: remove unnecessary params	2022-10-21 15:43:15 +00:00
debug.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
error_test.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
errors.go	gopls/internal/lsp: tolerate missing end position in RelatedInformation	2022-10-19 18:04:39 +00:00
graph.go	gopls/internal/lsp/cache: add PkgPath->PackageID index to Metadata	2022-10-20 21:54:57 +00:00
imports.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
keys.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
load.go	gopls/internal/lsp/cache: add PkgPath->PackageID index to Metadata	2022-10-20 21:54:57 +00:00
maps.go	gopls/internal/span: move internal/span into gopls	2022-10-07 14:50:44 +00:00
metadata.go	gopls/internal/lsp/cache: add PkgPath->PackageID index to Metadata	2022-10-20 21:54:57 +00:00
mod.go	gopls/internal/span: some cleanups	2022-10-13 13:15:27 +00:00
mod_tidy.go	gopls/internal/lsp/cache: better import path hygiene	2022-10-19 21:54:36 +00:00
os_darwin.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
os_windows.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
parse.go	internal/diff: ToUnified may fail	2022-10-07 15:16:55 +00:00
parse_test.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
parsemode_go116.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
parsemode_go117.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
pkg.go	gopls/internal/lsp: clarify control around diagnostics	2022-11-01 21:03:16 +00:00
session.go	gopls/internal/lsp: use the golang.org/x/vuln/exp/govulncheck	2022-10-11 21:42:28 +00:00
snapshot.go	gopls/internal/lsp/cache: remove unnecessary params	2022-10-21 15:43:15 +00:00
standalone_go115.go	gopls/internal/lsp/cache: add support for loading standalone main files	2022-10-13 15:07:40 +00:00
standalone_go116.go	gopls/internal/lsp/cache: remove stray print statement	2022-10-13 17:41:26 +00:00
standalone_go116_test.go	gopls: minor cleanup of standalone package support	2022-10-19 19:08:58 +00:00
symbols.go	gopls: migrate internal/lsp to gopls/internal/lsp	2022-09-07 16:44:44 +00:00
view.go	gopls/internal/lsp/cache: add support for loading standalone main files	2022-10-13 15:07:40 +00:00
view_test.go	gopls/internal/span: move internal/span into gopls	2022-10-07 14:50:44 +00:00
workspace.go	gopls/internal/span: move internal/span into gopls	2022-10-07 14:50:44 +00:00
workspace_test.go	gopls/internal/span: move internal/span into gopls	2022-10-07 14:50:44 +00:00