go/src
Josh Bleecher Snyder eb5cd0fb40 cmd/compile: mark Lsyms as readonly earlier
The SSA backend has rules to read the contents of readonly Lsyms.
However, this rule was failing to trigger for many readonly Lsyms.
This is because the readonly attribute that was set on the Node.Name
was not propagated to its Lsym until the dump globals phase, after SSA runs.

To work around this phase ordering problem, introduce Node.SetReadonly,
which sets Node.Name.Readonly and also configures the Lsym
enough that SSA can use it.

This change also fixes a latent problem in the rewrite rule function,
namely that reads past the end of lsym.P were treated as entirely zero,
instead of merely requiring padding with trailing zeros.

This change also adds an amd64 rule needed to fully optimize
the results of this change. It would be better not to need this,
but the zero extension that should handle this for us
gets optimized away too soon (see #36897 for a similar problem).
I have not investigated whether other platforms also need new
rules to take full advantage of the new optimizations.

Compiled code for (interface{})(true) on amd64 goes from:

LEAQ	type.bool(SB), AX
MOVBLZX	""..stmp_0(SB), BX
LEAQ	runtime.staticbytes(SB), CX
ADDQ	CX, BX

to

LEAQ	type.bool(SB), AX
LEAQ	runtime.staticbytes+1(SB), BX

Prior to this change, the readonly symbol rewrite rules
fired a total of 884 times during make.bash.
Afterwards they fire 1807 times.

file    before    after     Δ       %
cgo     4827832   4823736   -4096   -0.085%
compile 24907768  24895656  -12112  -0.049%
fix     3376952   3368760   -8192   -0.243%
pprof   14751700  14747604  -4096   -0.028%
total   120343528 120315032 -28496  -0.024%

Change-Id: I59ea52138276c37840f69e30fb109fd376d579ec
Reviewed-on: https://go-review.googlesource.com/c/go/+/220499
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2020-02-26 19:30:21 +00:00
..
archive
bufio all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
builtin
bytes bytes: deflake TestGrow by using testing.AllocsPerRun 2020-02-26 18:40:56 +00:00
cmd cmd/compile: mark Lsyms as readonly earlier 2020-02-26 19:30:21 +00:00
compress
container container/list: remove temporary variable `n` 2020-02-21 18:32:32 +00:00
context
crypto crypto/tls: use new ecdsa.VerifyASN1 API 2020-02-26 16:58:30 +00:00
database/sql database/sql: add SetConnMaxIdleTime 2020-02-21 18:36:57 +00:00
debug
encoding encoding/json: consolidate the isSpace function 2020-02-26 17:58:41 +00:00
errors
expvar
flag
fmt fmt: do not remove trailing zeros for %g and %G with #(sharp) flag 2020-02-26 08:43:57 +00:00
go all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
hash hash/maphash: add package-level example 2020-02-24 01:59:55 +00:00
html
image
index/suffixarray
internal os/exec: use environment variables for user token when present 2020-02-25 02:05:29 +00:00
io io: check n in testReadAtLeast 2020-02-21 18:36:11 +00:00
log
math math/big: initial vector arithmetic in riscv64 assembly 2020-02-25 16:47:02 +00:00
mime mime: fix ExtensionsByType bug when there are duplicates 2020-02-25 21:09:55 +00:00
net all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
os os/exec: use environment variables for user token when present 2020-02-25 02:05:29 +00:00
path
plugin
reflect all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
regexp
runtime all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
sort
strconv all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
strings all: avoid string(i) where i has type int 2020-02-26 04:38:19 +00:00
sync sync: add new Map method LoadAndDelete 2020-02-25 14:31:55 +00:00
syscall syscall: use dup3 in forkAndExecInChild1 if available 2020-02-24 08:31:48 +00:00
testdata
testing testing: change benchmark example function 2020-02-24 01:25:54 +00:00
text text/template: make reflect.Value indirections more robust 2020-02-24 09:16:18 +00:00
time time: add basic YYYY/MM/DD example to time docs 2020-02-25 04:34:15 +00:00
unicode
unsafe
vendor all: update module dependencies 2020-02-19 21:26:10 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update module dependencies 2020-02-19 21:26:10 +00:00
go.sum all: update module dependencies 2020-02-19 21:26:10 +00:00
iostest.bash
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.