go/gopls/internal
Robert Findley b243e57ea8 gopls/internal/lsp/tests: simplify collectCompletionItems, remove Data.t
The marker function collectCompletionItems required at least three
arguments. Express this in its signature, leaving a final variadic
argument for documentation. I considered just making this final argument
mandatory, but opted for minimizing the diff given that there are 400+
existing @item annotations.

With this change the only use of tests.Data.t is in mustRange. Since
conversion to range should always succeed, I switched this usage to a
panic and removed the t field.

For golang/go#54845

Change-Id: I407f07cb85fa1356ceb6dba366007f69d1b6a068
Reviewed-on: https://go-review.googlesource.com/c/tools/+/432337
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-09-23 13:52:05 +00:00
..
coverage gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
govulncheck gopls/internal/govulncheck: sync x/vuln@62b0186 2022-09-02 15:10:33 +00:00
hooks all: replace deprecated egrep with grep -E 2022-09-23 13:31:09 +00:00
lsp gopls/internal/lsp/tests: simplify collectCompletionItems, remove Data.t 2022-09-23 13:52:05 +00:00
regtest gopls: fix out of bounds bug in extract 2022-09-21 16:48:39 +00:00
vulncheck gopls/internal/lsp/source: remove Govulncheck from Hooks 2022-09-12 13:57:24 +00:00
migrate.sh gopls/internal/migrate.sh: a script to migrate internal/lsp to gopls/ 2022-09-07 14:10:36 +00:00