go/src
Ivan Trubach 060669a689 cmd/doc: make -src mode deterministic
These changes make cmd/doc -src deterministic, or, more precisely,
go/ast.MergePackageFiles, which is used by cmd/doc. So far the order of
comments depended on the package file map iteration order.

cmd/doc with -src flag has been inserting and omitting random comments
ever since the addition of -src flag. After investigating the code path
with the debugger, I’ve noticed that ast.File.Comments slice order changes
between invocations of the command. The bug was introduced in 3e24f2d,
which ironically claimed to “fix formatting of -src output”. The commit
implemented the collection of comments by iterating over the map and
c7cdce1 “godoc: make ?m=src mode deterministic” did’t actually make
go/ast.MergePackageFiles deterministic.

I’ve found this issue after running “go doc -src sync.WaitGroup.Wait”.
There are likely other packages and functions affected, but the bug
should be somewhat reproducible across all Go versions.

Change-Id: Iae223e99550c0a3b54005c5cde36f909e655b66b
GitHub-Last-Rev: c49532f79f
GitHub-Pull-Request: golang/go#33553
Reviewed-on: https://go-review.googlesource.com/c/go/+/189477
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2019-09-02 15:31:19 +00:00
..
archive archive/zip: remove unused special case 2019-08-27 17:00:43 +00:00
bufio bufio: fix ExampleScanner_Bytes comment, add error check 2019-06-25 00:29:24 +00:00
builtin
bytes bytes/hash: add hashing package for bytes and strings 2019-08-29 21:27:53 +00:00
cmd cmd/link: always set .dynsym info field 2019-09-01 23:59:23 +00:00
compress compress/flate: improve deflate performance by register allocating the index 2019-08-28 12:48:37 +00:00
container
context all: remove os.ErrTimeout 2019-08-02 17:57:18 +00:00
crypto crypto/x509: allow nil Certificates to be compared in Equal 2019-08-28 17:13:49 +00:00
database/sql std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
debug debug/pe: enable parsing of variable length optional header in PE file 2019-08-29 08:57:06 +00:00
encoding std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
errors errors: document Is and As methods 2019-08-27 16:51:42 +00:00
expvar all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
flag
fmt doc/go1.13: document fmt's number syntax updates 2019-08-23 23:40:29 +00:00
go cmd/doc: make -src mode deterministic 2019-09-02 15:31:19 +00:00
hash
html html/template: micro optimization for isJSType 2019-08-27 17:41:33 +00:00
image image/png: hoist repetitive pixels per byte out of loop in Encode 2019-08-28 09:02:35 +00:00
index/suffixarray
internal std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
io io/ioutil: don't check for short write in WriteFile 2019-09-01 02:31:50 +00:00
log
math math/big: fix a duplicate "the" in a comment 2019-09-02 11:42:47 +00:00
mime mime: update type of .js and .mjs files to text/javascript 2019-09-01 10:08:53 +00:00
net net: document concurrency safety and example for Dialer 2019-09-02 14:47:38 +00:00
os std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
path path: change the output format of ExampleSplit function 2019-09-01 10:08:36 +00:00
plugin
reflect std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
regexp std: remove unused bits of code all over the place 2019-09-02 12:57:37 +00:00
runtime runtime: remove outdated comment in select sortkey 2019-09-01 00:05:48 +00:00
sort
strconv strconv: Speed improvement to number parsing 2019-08-28 03:23:59 +00:00
strings strings: clarify usage of Title and ToTitle 2019-07-30 02:52:57 +00:00
sync sync: document implementation of Once.Do 2019-07-01 14:45:49 +00:00
syscall syscall: fix duplicate comments 2019-08-30 19:28:35 +00:00
testdata
testing Revert "cmd/go: move automatic testing.Init call into generated test code" 2019-07-22 21:42:51 +00:00
text text/template: avoid allocating a new common in copy 2019-08-27 16:56:26 +00:00
time time: update TestSub to avoid future regressions 2019-08-16 19:54:57 +00:00
unicode
unsafe
vendor net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
Make.dist
README.vendor all: update 'go get' command in standard library README.vendor 2019-08-23 21:07:49 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
go.sum net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
iostest.bash
make.bash
make.bat
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.