go/internal/lsp/cache
Robert Findley e55fb40e67 internal/lsp/cache: clear shouldLoad IDs on load
CL 417576 externalized shouldLoad tracking into a map, which was used to
trigger a reload and cleared once reload completes. Unfortunately, it
overlooked the fact that we may also reload the entire workspace (via
reinitialization). In this case, we should clear newly loaded IDs from
the shouldLoad map, so that they are not subsequently loaded again.

Fixes golang/go#54473

Change-Id: I26f49552cae502644142dc4a4e946294db37f6f7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/424074
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
2022-08-16 15:07:15 +00:00
..
analysis.go internal/lsp/cache: delete workspacePackageHandles (dead code) 2022-07-15 14:53:26 +00:00
cache.go internal/lsp/regtest: allow sharing memoized results across regtests 2022-07-26 21:20:42 +00:00
check.go internal/lsp/cache: invalid packages should not be workspace packages 2022-08-04 18:51:19 +00:00
debug.go internal/lsp/cache: build a new metadata graph on load 2022-06-16 15:50:09 +00:00
error_test.go internal/lsp/cache: split up sourceDiagnostics 2021-03-02 02:05:13 +00:00
errors.go internal/lsp: add unnecessary tags for unused vars and imports 2022-08-11 16:19:14 +00:00
graph.go internal/lsp/cache: tweaks to metadata graph 2022-08-16 01:59:44 +00:00
imports.go internal/lsp: use directoryFilters in import scanning 2022-08-04 15:50:11 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp/cache: clear shouldLoad IDs on load 2022-08-16 15:07:15 +00:00
maps.go internal/lsp/cache: simplify modtidy 2022-07-13 19:33:07 +00:00
metadata.go internal/lsp/cache: delete KnownMetadata.PkgFilesChanged 2022-08-04 18:51:46 +00:00
mod.go internal/memoize: rename Handle to Promise 2022-07-14 01:47:39 +00:00
mod_tidy.go internal/lsp/cache: report a critical error when go.work is invalid 2022-07-27 18:59:40 +00:00
os_darwin.go internal/lsp/cache: clarify an error message about mismatching casing 2021-08-03 17:18:10 +00:00
os_windows.go internal/lsp/cache: clarify an error message about mismatching casing 2021-08-03 17:18:10 +00:00
parse.go internal/memoize: rename Handle to Promise 2022-07-14 01:47:39 +00:00
parse_test.go internal/lsp/cache: don't trim unexported struct fields 2022-07-13 21:08:41 +00:00
parsemode_go116.go internal/lsp/cache: use cached parsed files for symbols, if available 2022-05-09 17:04:06 +00:00
parsemode_go117.go internal/lsp/cache: use cached parsed files for symbols, if available 2022-05-09 17:04:06 +00:00
pkg.go gopls: remove usage of golang.org/x/xerrors 2022-04-20 15:33:22 +00:00
session.go internal/lsp/cache: track explicit go.work files outside the workspace 2022-08-08 18:11:01 +00:00
snapshot.go internal/lsp/cache: tweaks to metadata graph 2022-08-16 01:59:44 +00:00
symbols.go internal/memoize: rename Handle to Promise 2022-07-14 01:47:39 +00:00
view.go internal/lsp/cache: tweaks to metadata graph 2022-08-16 01:59:44 +00:00
view_test.go internal/lsp: Update FilterDisallow to support matching directories at arbitrary depth. 2022-07-18 17:53:36 +00:00
workspace.go internal/lsp/cache: track explicit go.work files outside the workspace 2022-08-08 18:11:01 +00:00
workspace_test.go internal/lsp/cache: track explicit go.work files outside the workspace 2022-08-08 18:11:01 +00:00