go/internal
Hana 54af36eca2 internal/lsp: handle invalid URL args in command params
beginFileRequest returns a nil error when file request url is
not a valid file url format. This is reported with a separate 'ok'
boolean return value.

This bug caused custom gopls commands to return success with
an empty result, instead of reporting the problem as an error.

Change-Id: I8eed39368087fa9928bcc68853225ea432f500d2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/395814
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-03-25 15:45:26 +00:00
..
analysisinternal go/analysis/passes/tests: Check malformed fuzz target. 2022-02-16 18:26:19 +00:00
apidiff all: add copyright notices to files that are missing them 2021-01-06 17:23:47 +00:00
event internal/lsp/debug: add a facility to track known bugs 2021-05-10 23:21:19 +00:00
fakenet
fastwalk x/tools/internal/fastwalk: fixes "interrupted system call" error 2021-02-24 01:32:32 +00:00
gocommand internal/imports: update to permit multiple main modules 2022-02-22 17:36:43 +00:00
gopathwalk
imports internal/imports: update stdlib index for 1.18 2022-03-16 21:19:09 +00:00
jsonrpc2 internal/jsonrpc2: make Serve wait for all connections to close 2021-11-08 20:32:21 +00:00
jsonrpc2_v2 tools: fix some typos 2022-03-24 22:24:35 +00:00
lsp internal/lsp: handle invalid URL args in command params 2022-03-25 15:45:26 +00:00
memoize internal/memoize: do not allow (*Generation).Acquire to fail 2021-12-02 03:25:35 +00:00
packagesinternal internal/lsp/cache: disable network for mod tidy diagnostics 2021-02-05 19:41:14 +00:00
proxydir
span internal/span: fix a comment about windows drive letters 2021-08-03 19:59:22 +00:00
stack
testenv gopls/internal/regtest/codelens: use the test's deadline instead of a hard-coded timeout 2022-01-24 16:28:24 +00:00
tool gopls: cleanup the main help pages 2022-02-02 14:57:28 +00:00
typeparams internal/typeparams: add a generic form of types.AssignableTo 2022-02-08 16:50:25 +00:00
typesinternal internal/typesinternal: update typesinternal for 1.18 2022-02-22 16:42:18 +00:00
xcontext