go/test at dd678172e378e62cc85d075676e040354f4628da - go

History

Keith Randall dbaa2d3e65 cmd/compile: do nil check before calling duff functions, on arm64 and amd64 On these platforms, we set up a frame pointer record below the current stack pointer, so when we're in duffcopy or duffzero, we get a reasonable traceback. See #73753. But because this frame pointer record is below SP, it is vulnerable. Anything that adds a new stack frame to the stack might clobber it. Which actually happens in #73748 on amd64. I have not yet come across a repro on arm64, but might as well be safe here. The only real situation this could happen is when duffzero or duffcopy is passed a nil pointer. So we can just avoid the problem by doing the nil check outside duffzero/duffcopy. That way we never add a frame below duffzero/duffcopy. (Most other ways to get a new frame below the current one, like async preempt or debugger-generated calls, don't apply to duffzero/duffcopy because they are runtime functions; we're not allowed to preempt there.) Longer term, we should stop putting stuff below SP. #73753 will include that as part of its remit. But that's not for 1.25, so we'll do the simple thing for 1.25 for this issue. Fixes #73748 Change-Id: I913c49ee46dcaee8fb439415a4531f7b59d0f612 Reviewed-on: https://go-review.googlesource.com/c/go/+/676916 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Keith Randall <khr@google.com>		2025-05-28 20:35:09 -07:00
..
abi	…
alias3.dir	…
arenas	…
asmhdr.dir	…
chan	…
closure3.dir	…
closure5.dir	…
codegen	cmd/compile/internal/ssa: eliminate string copies for calls to unique.Make	2025-05-21 20:20:31 -07:00
ddd2.dir	…
dwarf	…
fixedbugs	cmd/compile: do nil check before calling duff functions, on arm64 and amd64	2025-05-28 20:35:09 -07:00
import2.dir	…
import4.dir	…
interface	…
internal/runtime/sys	…
intrinsic.dir	…
ken	…
linkname.dir	…
linknameasm.dir	…
method4.dir	…
retjmp.dir	…
stress	…
syntax	…
typeparam	…
uintptrescapes.dir	…
wasmmemsize.dir	…
64bit.go	…
235.go	…
README.md	…
alg.go	…
alias.go	…
alias1.go	…
alias2.go	…
alias3.go	…
align.go	…
append.go	…
append1.go	…
args.go	…
armimm.go	…
asmhdr.go	…
assign.go	…
assign1.go	…
atomicload.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	…
bom.go	…
bombad.go	…
bounds.go	…
cannotassign.go	…
chancap.go	…
chanlinear.go	…
char_lit.go	…
char_lit1.go	…
checkbce.go	…
clear.go	…
clearfat.go	…
closedchan.go	…
closure.go	…
closure1.go	…
closure2.go	…
closure3.go	…
closure4.go	…
closure5.go	…
closure6.go	…
closure7.go	…
cmp.go	…
cmp6.go	…
cmplx.go	…
cmplxdivide.c	…
cmplxdivide.go	…
cmplxdivide1.go	…
complit.go	…
complit1.go	…
compos.go	…
const.go	…
const1.go	…
const2.go	…
const3.go	…
const4.go	…
const5.go	…
const6.go	…
const7.go	…
const8.go	…
convT2X.go	…
convert.go	…
convert1.go	…
convert2.go	…
convert3.go	…
convert4.go	…
convinline.go	…
convlit.go	…
convlit1.go	…
copy.go	…
copy1.go	…
crlf.go	…
ddd.go	…
ddd1.go	…
ddd2.go	…
decl.go	…
declbad.go	…
defer.go	…
defererrcheck.go	…
deferfin.go	…
defernil.go	…
deferprint.go	…
deferprint.out	…
devirt.go	…
directive.go	…
directive2.go	…
divide.go	…
divmod.go	…
embedfunc.go	…
embedvers.go	…
empty.go	…
env.go	…
eof.go	…
eof1.go	…
escape.go	…
escape2.go	cmd/compile: allocate backing store for append on the stack	2025-05-19 16:14:53 -07:00
escape2n.go	cmd/compile: allocate backing store for append on the stack	2025-05-19 16:14:53 -07:00
escape3.go	…
escape4.go	…
escape5.go	cmd/compile/internal/escape: propagate constants to interface conversions to avoid allocs	2025-05-21 12:02:43 -07:00
escape6.go	cmd/compile: allow pointer-containing elements in stack allocations	2025-04-04 15:04:34 -07:00
escape_array.go	…
escape_calls.go	cmd/compile: allocate backing store for append on the stack	2025-05-19 16:14:53 -07:00
escape_closure.go	…
escape_field.go	…
escape_goto.go	…
escape_hash_maphash.go	…
escape_iface.go	cmd/compile/internal/escape: propagate constants to interface conversions to avoid allocs	2025-05-21 12:02:43 -07:00
escape_iface_data.go	cmd/compile/internal/walk: use global zeroVal in interface conversions for zero values	2025-05-21 12:24:22 -07:00
escape_indir.go	…
escape_level.go	…
escape_make_non_const.go	cmd/compile: stack allocate variable-sized makeslice	2025-04-04 10:36:58 -07:00
escape_map.go	cmd/compile: allocate backing store for append on the stack	2025-05-19 16:14:53 -07:00
escape_mutations.go	…
escape_param.go	…
escape_reflect.go	…
escape_runtime_atomic.go	…
escape_selfassign.go	…
escape_slice.go	cmd/compile: allocate backing store for append on the stack	2025-05-19 16:14:53 -07:00
escape_struct_param1.go	…
escape_struct_param2.go	…
escape_struct_return.go	…
escape_sync_atomic.go	…
escape_unique.go	cmd/compile, unique: model data flow of non-string pointers	2025-05-21 20:07:36 -07:00
escape_unsafe.go	…
fibo.go	…
finprofiled.go	…
float_lit.go	…
float_lit2.go	…
float_lit3.go	…
floatcmp.go	…
for.go	…
func.go	…
func1.go	…
func2.go	…
func3.go	…
func4.go	…
func5.go	…
func6.go	…
func7.go	…
func8.go	…
funcdup.go	…
funcdup2.go	…
fuse.go	…
gc.go	…
gc1.go	…
gc2.go	…
gcgort.go	…
gcstring.go	…
goprint.go	…
goprint.out	…
goto.go	…
heapsampling.go	…
helloworld.go	…
helloworld.out	…
if.go	…
import.go	…
import1.go	…
import2.go	…
import4.go	…
import5.go	…
import6.go	…
index.go	…
index0.go	…
index1.go	…
index2.go	…
indirect.go	…
indirect1.go	…
init.go	…
init1.go	…
initcomma.go	…
initexp.go	…
initialize.go	…
initializerr.go	…
initloop.go	…
inline.go	…
inline_big.go	…
inline_caller.go	…
inline_callers.go	…
inline_endian.go	cmd/compile: allocate backing store for append on the stack	2025-05-19 16:14:53 -07:00
inline_literal.go	…
inline_math_bits_rotate.go	…
inline_sync.go	sync: use atomic.Bool for Once.done	2025-04-22 08:28:13 -07:00
inline_testingbloop.go	testing: detect a stopped timer in B.Loop	2025-03-24 11:41:09 -07:00
inline_variadic.go	…
int_lit.go	…
intcvt.go	…
intrinsic.go	…
intrinsic_atomic.go	…
iota.go	…
label.go	…
label1.go	…
linkmain.go	…
linkmain_run.go	…
linkname.go	…
linkname3.go	…
linknameasm.go	…
linkobj.go	…
linkx.go	…
linkx_run.go	…
literal.go	…
literal2.go	…
live.go	cmd/compile/internal/walk: convert composite literals to interfaces without allocating	2025-05-21 12:23:26 -07:00
live1.go	…
live2.go	…
live_regabi.go	cmd/compile/internal/walk: convert composite literals to interfaces without allocating	2025-05-21 12:23:26 -07:00
live_uintptrkeepalive.go	…
loopbce.go	…
mainsig.go	…
makechan.go	…
makemap.go	…
makenew.go	…
makeslice.go	…
mallocfin.go	…
map.go	…
map1.go	…
mapclear.go	…
maplinear.go	…
maymorestack.go	…
mergemul.go	…
method.go	…
method1.go	…
method2.go	…
method3.go	…
method4.go	…
method5.go	…
method6.go	…
method7.go	…
named.go	…
named1.go	…
newinline.go	…
nil.go	…
nilcheck.go	…
nilptr.go	cmd/link: use >4GB base address for 64-bit PE binaries	2025-05-12 11:05:28 -07:00
nilptr2.go	…
nilptr3.go	…
nilptr4.go	…
nilptr5.go	…
nilptr5_aix.go	…
nilptr5_wasm.go	…
nilptr_aix.go	…
noinit.go	…
nosplit.go	…
nowritebarrier.go	…
nul1.go	…
opt_branchlikely.go	…
parentype.go	…
peano.go	…
phiopt.go	cmd/compile: add 2 phiopt cases	2025-05-08 10:18:37 -07:00
print.go	…
print.out	…
printbig.go	…
printbig.out	…
prove.go	…
prove_constant_folding.go	…
prove_invert_loop_with_unused_iterators.go	…
prove_popcount.go	cmd/compile: compute bits.OnesCount's limits from argument's limits	2025-03-11 20:17:36 -07:00
range.go	…
range2.go	…
range3.go	…
range4.go	…
rangegen.go	…
recover.go	…
recover1.go	…
recover2.go	…
recover3.go	…
recover4.go	…
recover5.go	…
reflectmethod1.go	…
reflectmethod2.go	…
reflectmethod3.go	…
reflectmethod4.go	…
reflectmethod5.go	…
reflectmethod6.go	…
reflectmethod7.go	…
reflectmethod8.go	…
rename.go	…
rename1.go	…
reorder.go	…
reorder2.go	…
retjmp.go	…
return.go	…
rotate.go	…
rotate0.go	…
rotate1.go	…
rotate2.go	…
rotate3.go	…
rune.go	…
runtime.go	…
shift1.go	…
shift2.go	…
shift3.go	…
sieve.go	…
sigchld.go	…
sigchld.out	…
simassign.go	…
sizeof.go	…
slice3.go	…
slice3err.go	…
slicecap.go	…
sliceopt.go	…
solitaire.go	…
stack.go	…
stackobj.go	…
stackobj2.go	…
stackobj3.go	…
strcopy.go	…
strength.go	…
string_lit.go	…
stringrange.go	…
struct0.go	…
switch.go	…
switch2.go	…
switch3.go	…
switch4.go	…
switch5.go	…
switch6.go	…
switch7.go	…
tailcall.go	…
tighten.go	…
tinyfin.go	…
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	…
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	…
typeswitch2b.go	…
typeswitch3.go	…
uintptrescapes.go	…
uintptrescapes2.go	…
uintptrescapes3.go	…
uintptrkeepalive.go	…
undef.go	…
unsafe_slice_data.go	…
unsafe_string.go	…
unsafe_string_data.go	…
unsafebuiltins.go	…
used.go	…
utf.go	…
varerr.go	…
varinit.go	…
wasmexport.go	…
wasmexport2.go	…
wasmmemsize.go	…
weak.go	…
winbatch.go	…
writebarrier.go	…
zerodivide.go	…
zerosize.go	…

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go test cmd/internal/testdir

To run just tests from specified files in this directory, execute:

../bin/go test cmd/internal/testdir -run='Test/(file1.go|file2.go|...)'

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.