Now that the bare minimum change to make the run.go test runner into a normal go test is done, there remain many opportunities to simplify, modernize and generally clean up the test code. Of all the opportunities available, this change tries to fit somewhere between doing "not enough" and "way too much". This ends up including: • replace verbose flag with testing.Verbose() • replace custom temporary directory creation, removal, -keep flag with testing.T.TempDir • replace custom code to find the go command with testenv.GoToolPath • replace many instances of "t.err = err; return" with "return err", or with t.Fatal when it's clearly a test infrastructure error • replace reliance on changing working directory to GOROOT/test to computing and using absolute paths • replace uses of log.Fatal with t.Fatal • replace uses of deprecated ioutil package with their replacements • add some missing error checks, use more idiomatic identifier names For #56844. Change-Id: I5b301bb83a8e5b64cf211d7f2f4b14d38d48fea0 Reviewed-on: https://go-review.googlesource.com/c/go/+/466155 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| codereview.cfg | ||
| go.env | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.