go/src
Roland Shoemaker dc50683bf7 crypto/elliptic: upgrade from generic curve impl to specific if available
This change alters the CurveParam methods to upgrade from the generic
curve implementation to the specific P224 or P256 implementations when
called on the embedded CurveParams. This removes the trap of using
elliptic.P224().Params() instead of elliptic.P224(), for example, which
results in using the generic implementation instead of the optimized
constant time one. For P224 this is done for all of the CurveParams
methods, except Params, as the optimized implementation covers all
these methods. For P256 this is only done for ScalarMult and
ScalarBaseMult, as despite having implementations of addition and
doubling they aren't exposed and instead the generic implementation is
used. For P256 an additional check that there actually is a specific
implementation is added, as unlike the P224 implementation the P256 one
is only available on certain platforms.

This change takes the simple, fast approach to checking this, it simply
compares pointers. This removes the most obvious class of mistakes
people make, but still allows edge cases where the embedded CurveParams
pointer has been dereferenced (as seen in the unit tests) or when someone
has manually constructed their own CurveParams that matches one of the
standard curves. A more complex approach could be taken to also address
these cases, but it would require directly comparing all of the
CurveParam fields which would, in the worst case, require comparing
against two standard CurveParam sets in the ScalarMult and
ScalarBaseMult paths, which are likely to be the hottest already.

Updates #34648

Change-Id: I82d752f979260394632905c15ffe4f65f4ffa376
Reviewed-on: https://go-review.googlesource.com/c/go/+/233939
Trust: Roland Shoemaker <roland@golang.org>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
2021-05-10 19:19:34 +00:00
..
archive archive/zip: add File.OpenRaw, Writer.CreateRaw, Writer.Copy 2021-05-03 21:11:47 +00:00
bufio bufio: mention ErrFinalToken in SplitFunc documentation 2021-04-30 19:34:38 +00:00
builtin
bytes
cmd cmd/internal/objfile: add objabi.SNOPTRDATA to "D" 2021-05-10 18:10:43 +00:00
compress
container
context
crypto crypto/elliptic: upgrade from generic curve impl to specific if available 2021-05-10 19:19:34 +00:00
database/sql database/sql: add NullInt16 and NullByte 2021-05-04 17:31:29 +00:00
debug
embed embed/internal/embedtest: add test for embedded path starting with dash 2021-05-04 23:35:34 +00:00
encoding encoding/csv: add FieldPos method 2021-04-29 17:47:48 +00:00
errors
expvar
flag
fmt
go go/build: include files with parse errors in GoFiles and other lists 2021-05-10 15:53:43 +00:00
hash
html text/template: add lock for Template.tmpl to fix data race 2021-05-04 00:03:39 +00:00
image
index/suffixarray
internal cmd/compile,reflect: allow longer type names 2021-05-10 13:16:56 +00:00
io
log
math math/big: check for excessive exponents in Rat.SetString 2021-05-06 16:00:55 +00:00
mime net/http: ignore directory path when parsing multipart forms 2021-05-05 18:14:49 +00:00
net net, runtime: drop macOS 10.12 skip conditions in tests 2021-05-10 15:49:50 +00:00
os os: skip TestExecutableDeleted on plan9 2021-05-04 18:47:19 +00:00
path path/filepath: fix documentation typo (was "each each") 2021-05-02 18:13:38 +00:00
plugin
reflect cmd/compile,reflect: allow longer type names 2021-05-10 13:16:56 +00:00
regexp
runtime runtime/cgo,cmd/internal/obj/ppc64: fix signals with cgo 2021-05-10 17:21:32 +00:00
sort
strconv strconv: fix a typo 2021-05-04 03:22:47 +00:00
strings
sync sync/atomic: add (*Value).Swap and (*Value).CompareAndSwap 2021-05-04 00:15:27 +00:00
syscall runtime,syscall: convert syscall on openbsd/arm to libc 2021-05-09 17:07:01 +00:00
testdata
testing testing: add -shuffle=off|on|N to alter the execution order of tests and benchmarks 2021-04-28 16:06:21 +00:00
text text/template: fix type bug in eq 2021-05-06 13:39:39 +00:00
time time: make time.Time print a valid Go string with %#v 2021-05-02 20:59:26 +00:00
unicode
unsafe
vendor all: update vendored dependencies for Go 1.17 2021-05-05 15:53:03 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies for Go 1.17 2021-05-05 15:53:03 +00:00
go.sum all: update vendored dependencies for Go 1.17 2021-05-05 15:53:03 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.