go/src
Michael Anthony Knyszek d93f6df0cc reflect: correctly handle method values in Seq
Currently method values aren't correctly handled in Seq because we call
canRangeFunc on the reciever type, not the method value type, when we're
handling a method value. reflect.Value.Type has the logic to obtain the
method value type from the Value.

This change slightly refactors reflect.Value.Type into a separate
function so we can obtain the correct type as an abi.Type and pass it
off to canRangeFunc (and canRangeFunc2).

Fixes #71874.

Change-Id: Ie62dfca2a84b8f2f816bb87ff1ed1a58a7bb8122
Reviewed-on: https://go-review.googlesource.com/c/go/+/651416
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
2025-02-21 09:17:39 -08:00
..
archive io/fs: add ReadLinkFS interface 2025-02-03 08:38:43 -08:00
arena
bufio bufio: skip network test if unixpacket socket not supported 2025-02-07 11:37:07 -08:00
builtin builtin: use list instead of indentation for comments in cap, len, and make 2024-12-30 15:59:23 -08:00
bytes bytes,strings: remove redundant return statement for Lines 2025-02-19 10:22:08 -08:00
cmd cmd/compile: remove residual register GC map code 2025-02-20 12:51:47 -08:00
cmp
compress all: use a more straightforward return value 2025-02-18 09:28:50 -08:00
container
context context: replace newAfterFuncContext with a global declaration using blank identifier 2025-02-20 08:16:29 -08:00
crypto crypto/tls: improve ech parsing errors 2025-02-19 19:33:58 -08:00
database/sql database/sql: use t.Context in tests 2025-02-10 12:34:55 -08:00
debug debug/buildinfo: base64-encode test binaries 2025-02-20 14:20:00 -08:00
embed embed: document exclusions more explicitly 2024-12-05 17:20:19 +00:00
encoding encoding/base64: use internal/byteorder 2025-02-06 16:40:55 -08:00
errors
expvar
flag
fmt fmt, strconv: document that exponent is always two digits 2024-12-17 07:54:13 -08:00
go go/*: use go/types.Func.Signature and go/ast.Preorder 2025-02-19 19:25:33 -08:00
hash hash/maphash, cmd/compile: make Comparable[string] not escape its argument 2024-12-02 21:27:06 +00:00
html html/template: add available godoc link 2025-02-19 13:39:04 -08:00
image internal/byteorder: use canonical Go casing in names 2024-11-20 20:59:28 +00:00
index/suffixarray
internal internal/runtime/atomic: add Xchg8 for mips64x 2025-02-20 09:44:53 -08:00
io std: add //go:fix inline directives to some deprecated functions 2025-02-15 08:06:58 -08:00
iter iter: improve documentation with iterator example 2024-12-27 05:44:33 -08:00
log all: use a more straightforward return value 2025-02-18 09:28:50 -08:00
maps all: fix some function names and typos in comment 2024-11-21 22:16:20 +00:00
math math/big: use built-in max function 2025-02-03 08:25:31 -08:00
mime mime: disable TestLookupMallocs with ASAN 2024-11-19 02:54:28 +00:00
net all: use a more straightforward return value 2025-02-18 09:28:50 -08:00
os os: don't log the entire environment in tests 2025-02-20 22:15:35 -08:00
path path/filepath: use RtlIsDosDeviceName_U to detect Windows devices 2025-02-19 09:41:00 -08:00
plugin
reflect reflect: correctly handle method values in Seq 2025-02-21 09:17:39 -08:00
regexp
runtime all: implement plugin build mode for riscv64 2025-02-19 17:54:34 -08:00
slices slices: document two oddities 2024-12-21 08:22:08 -08:00
sort sort: add examples for SearchStrings, SliceIsSorted 2024-12-03 17:07:42 +00:00
strconv strconv: adjust comment so that gofmt doesn't mung it 2025-01-27 13:16:45 -08:00
strings bytes,strings: remove redundant return statement for Lines 2025-02-19 10:22:08 -08:00
structs
sync sync: use runtime.AddCleanup instead of runtime.SetFinalizer 2025-02-14 07:29:34 -08:00
syscall runtime: use WCLONE when waiting on pidfd test child 2025-02-21 08:57:04 -08:00
testdata
testing testing: panic in AllocsPerRun if parallel tests are running 2025-02-14 06:09:08 -08:00
text text/template: handle UnsafePointer in isTrue 2025-02-10 08:21:56 -08:00
time internal/synctest: new package for testing concurrent code 2024-11-19 19:40:40 +00:00
unicode unicode/utf8: remove init from utf8_test 2025-02-06 14:13:50 -08:00
unique unique: fix typo 2024-12-30 08:59:20 -08:00
unsafe
vendor net/http, net/http/internal/httpcommon: add httpcommon package 2025-02-13 16:29:58 -08:00
weak weak: accept linker-allocated objects to Make 2025-02-19 14:25:00 -08:00
Make.dist
README.vendor
all.bash
all.bat {all,clean,make,race,run}.bat: simplify error handling 2025-02-11 09:45:10 -08:00
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat {all,clean,make,race,run}.bat: simplify error handling 2025-02-11 09:45:10 -08:00
clean.rc
cmp.bash
go.mod net/http, net/http/internal/httpcommon: add httpcommon package 2025-02-13 16:29:58 -08:00
go.sum net/http, net/http/internal/httpcommon: add httpcommon package 2025-02-13 16:29:58 -08:00
make.bash
make.bat make.bat,race.bat: simplify --dist-tool handling 2025-02-11 23:09:26 -08:00
make.rc make.rc: correct test for undefined GOROOT_BOOTSTRAP 2024-11-14 18:02:59 +00:00
race.bash
race.bat make.bat,race.bat: simplify --dist-tool handling 2025-02-11 23:09:26 -08:00
run.bash
run.bat {all,clean,make,race,run}.bat: simplify error handling 2025-02-11 09:45:10 -08:00
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Also, ensure that 'go env GOROOT' shows the root of this Go source
tree. Otherwise, the results are undefined. It's recommended to build
Go from source and use that 'go' binary to update its source tree.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.